From: krkk <krkk@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] mumble: fix plugin path
Date: Thu, 10 Dec 2020 17:24:45 +0100 [thread overview]
Message-ID: <20201210162445.XE1vkTp2u15UXUv42D7_KYlYNKiRE7EL9XmPuf6qCic@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27065@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
There is an updated pull request by krkk against master on the void-packages repository
https://github.com/krkk/void-packages fix-mumble-plugin
https://github.com/void-linux/void-packages/pull/27065
mumble: fix plugin path
https://github.com/mumble-voip/mumble/blob/1.3.3/src/mumble/Plugins.cpp#L212-L220
Mumble was searching plugins in `/usr/bin/plugins/` because `MumbleApplication::applicationVersionRootPath()`(basically the `QCoreApplication::applicationDirPath()`) returns the path of the application executable.
A patch file from https://github.com/void-linux/void-packages/pull/27065.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-mumble-plugin-27065.patch --]
[-- Type: text/x-diff, Size: 1416 bytes --]
From a818e000817fd8ea922ee59ffa3bd709fc9768ba Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 10 Dec 2020 08:46:00 +0100
Subject: [PATCH] mumble: fix plugin path
Mumble was searching plugins in /usr/bin/plugins/
because MumbleApplication::applicationVersionRootPath()
(basically the QCoreApplication::applicationDirPath()) returns the path
of the application executable.
https://github.com/mumble-voip/mumble/blob/1.3.3/src/mumble/Plugins.cpp#L212-L220
---
srcpkgs/mumble/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/mumble/template b/srcpkgs/mumble/template
index 981e3ab8f06..ad50b5ae954 100644
--- a/srcpkgs/mumble/template
+++ b/srcpkgs/mumble/template
@@ -1,12 +1,12 @@
# Template file for 'mumble'
pkgname=mumble
version=1.3.3
-revision=2
+revision=3
build_style=qmake
configure_args="CONFIG+=bundled-celt CONFIG+=no-bundled-opus CONFIG+=no-update
CONFIG+=no-bundled-speex CONFIG+=no-g15 CONFIG+=no-xevie CONFIG+=pulseaudio
$(vopt_if jack CONFIG+=jackaudio) CONFIG+=no-embed-qt-translations
- CONFIG+=no-oss CONFIG+=portaudio"
+ CONFIG+=no-oss CONFIG+=portaudio DEFINES+=PLUGIN_PATH=/usr/lib/mumble"
hostmakedepends="Ice pkg-config protobuf qt5-host-tools qt5-qmake python3 which"
makedepends="Ice-devel MesaLib-devel avahi-compat-libs-devel boost-devel
libcap-devel libressl-devel libsndfile-devel opus-devel protobuf-devel
next prev parent reply other threads:[~2020-12-10 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 8:21 [PR PATCH] " krkk
2020-12-10 13:30 ` ericonr
2020-12-10 16:24 ` krkk [this message]
2020-12-11 3:52 ` ericonr
2020-12-11 3:52 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210162445.XE1vkTp2u15UXUv42D7_KYlYNKiRE7EL9XmPuf6qCic@z \
--to=krkk@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).