From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: 99-pkglint-subpkgs: simplify and correct
Date: Mon, 14 Dec 2020 03:35:05 +0100 [thread overview]
Message-ID: <20201214023505.weF9WMV_qnATh8neNPEYupQV-99LxMzEHiuH3lKsELs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26950@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
There's a merged pull request on the void-packages repository
99-pkglint-subpkgs: simplify and correct
https://github.com/void-linux/void-packages/pull/26950
Description:
As discussing in [1], on template with "subpackages" as multilines will
report false positive on some packages will never be built.
There're multiple problems here:
- expanded "subpackages" will have an empty line if it has a newline
inside template
- "sed" expression couldn't work with multilines "subpackages"
Let's not quote "$subpkgs" and "$subpackages" in "printf" to let the
shell do expansion and trim the empty lines for us. And rewrite the
"sed" expression to work with multilines "subpackages"
[1]: https://github.com/void-linux/void-packages/pull/26939#issuecomment-739098547
prev parent reply other threads:[~2020-12-14 2:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 1:41 [PR PATCH] " sgn
2020-12-05 3:44 ` [PR PATCH] [Updated] " sgn
2020-12-07 0:03 ` [PR PATCH] [Closed]: " sgn
2020-12-07 9:03 ` [PR REVIEW] " Piraty
2020-12-07 9:03 ` Piraty
2020-12-07 11:29 ` sgn
2020-12-07 11:34 ` [PR PATCH] [Updated] " sgn
2020-12-07 12:59 ` sgn
2020-12-07 12:59 ` sgn
2020-12-09 18:29 ` [PR REVIEW] " ericonr
2020-12-10 0:13 ` [PR PATCH] [Updated] " sgn
2020-12-10 0:14 ` [PR REVIEW] " sgn
2020-12-10 0:27 ` ericonr
2020-12-10 0:39 ` [PR PATCH] [Updated] " sgn
2020-12-10 14:23 ` sgn
2020-12-14 2:35 ` sgn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214023505.weF9WMV_qnATh8neNPEYupQV-99LxMzEHiuH3lKsELs@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).