Github messages for voidlinux
 help / color / mirror / Atom feed
From: deepcube <deepcube@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: broadcom-wl-dkms: add linux-5.9.patch
Date: Thu, 17 Dec 2020 18:42:39 +0100	[thread overview]
Message-ID: <20201217174239.E-q9BXLmtZh9Fn6G4S7Te4AD42vIpYpcnywZ01iTZ_k@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27202@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

New comment by deepcube on void-packages repository

https://github.com/void-linux/void-packages/pull/27202#issuecomment-747592340

Comment:
On Thu Dec 17, 2020 at 5:54 AM PST, Érico Nogueira Rolim wrote:
> Does this still work with older kernels?

Yes.

I have performed a minimal test on the 5.8 and LTS kernels (5.4, 4.19,
4.9, 4.4).  For all of them the driver builds, probes, the interface
appears, and I can pass traffic.

For this change:

	-	if (segment_eq(get_fs(), KERNEL_DS))
	+	if (get_fs().seg == KERNEL_DS.seg)

The segment_eq macro was:

	#define segment_eq(a, b) ((a).seg == (b).seg)

So the new code is just expanding that manually.

I will admit I'm not as clear on this change:

	-	set_fs(get_ds());
	+	set_fs(KERNEL_DS);

But my hunch is that it's acceptable as the earlier block was already
using KERNEL_DS instead of get_ds().


  parent reply	other threads:[~2020-12-17 17:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 18:54 [PR PATCH] " deepcube
2020-12-17 13:53 ` ericonr
2020-12-17 17:42 ` deepcube [this message]
2020-12-17 18:01 ` ericonr
2020-12-17 18:01 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201217174239.E-q9BXLmtZh9Fn6G4S7Te4AD42vIpYpcnywZ01iTZ_k@z \
    --to=deepcube@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).