From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] ffms2: update to 2.40.
Date: Sun, 20 Dec 2020 23:54:55 +0100 [thread overview]
Message-ID: <20201220225455.K_VwX_luI4MZiHOJCxFMNX0u4LxjnXsccIaIicn2kkM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25850@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25850#discussion_r546448251
Comment:
It isn't fine to stop building the package for a target, since it has dependants.
The issue here is the lack of `libatomic-devel`. It might be enough to add
```
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
makedepends+=" libatomic-devel"
fi
```
to the template.
next prev parent reply other threads:[~2020-12-20 22:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 17:14 [PR PATCH] " DirectorX
2020-10-24 18:01 ` [PR PATCH] [Updated] " DirectorX
2020-10-24 18:16 ` DirectorX
2020-10-26 19:46 ` DirectorX
2020-12-20 4:45 ` ericonr
2020-12-20 9:20 ` [PR PATCH] [Updated] " DirectorX
2020-12-20 9:50 ` DirectorX
2020-12-20 10:05 ` DirectorX
2020-12-20 10:33 ` DirectorX
2020-12-20 10:41 ` DirectorX
2020-12-20 10:46 ` DirectorX
2020-12-20 10:49 ` DirectorX
2020-12-20 22:54 ` ericonr [this message]
2020-12-20 22:55 ` [PR REVIEW] " ericonr
2020-12-21 12:50 ` [PR PATCH] [Updated] " DirectorX
2020-12-21 12:54 ` DirectorX
2020-12-21 15:25 ` [PR PATCH] [Closed]: " ericonr
2020-12-21 15:25 ` ericonr
2020-11-24 22:06 [PR PATCH] " concatime
2020-11-24 22:28 ` [PR REVIEW] " ericonr
2020-11-24 22:40 ` concatime
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201220225455.K_VwX_luI4MZiHOJCxFMNX0u4LxjnXsccIaIicn2kkM@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).