From: aweagel <aweagel@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: jump-0.30.1
Date: Mon, 21 Dec 2020 14:26:46 +0100 [thread overview]
Message-ID: <20201221132646.bXyBAy7KmZbJhBchnQBWbGvGQcKVxaKY6iZFivuAsgE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27245@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
New review comment by aweagel on void-packages repository
https://github.com/void-linux/void-packages/pull/27245#discussion_r546704096
Comment:
Hmm, I see this being done in lots of package definitions (see [hub](https://github.com/void-linux/void-packages/blob/master/srcpkgs/hub/template), [erlang](https://github.com/void-linux/void-packages/blob/master/srcpkgs/erlang/template), [mpv](https://github.com/void-linux/void-packages/blob/master/srcpkgs/mpv/template), [obs](https://github.com/void-linux/void-packages/blob/master/srcpkgs/obs/template), [skaffold](https://github.com/void-linux/void-packages/blob/master/srcpkgs/skaffold/template), [sysdig](https://github.com/void-linux/void-packages/blob/master/srcpkgs/sysdig/template), etc).
Are you sure it's better to remove it, or would it make sense to follow the existing convention? I don't have a strong preference.
next prev parent reply other threads:[~2020-12-21 13:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 0:05 [PR PATCH] " aweagel
2020-12-18 13:16 ` aweagel
2020-12-18 13:20 ` aweagel
2020-12-18 17:25 ` [PR REVIEW] " Vaelatern
2020-12-18 17:29 ` Vaelatern
2020-12-19 0:38 ` [PR PATCH] [Updated] " aweagel
2020-12-19 0:44 ` [PR REVIEW] " aweagel
2020-12-19 0:45 ` aweagel
2020-12-19 0:47 ` aweagel
2020-12-20 20:29 ` Vaelatern
2020-12-21 13:25 ` aweagel
2020-12-21 13:26 ` aweagel [this message]
2020-12-22 0:25 ` Vaelatern
2020-12-22 4:59 ` [PR PATCH] [Merged]: " Vaelatern
2020-12-22 4:59 ` Vaelatern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221132646.bXyBAy7KmZbJhBchnQBWbGvGQcKVxaKY6iZFivuAsgE@z \
--to=aweagel@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).