From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] xfce4-4.16
Date: Wed, 23 Dec 2020 14:57:33 +0100 [thread overview]
Message-ID: <20201223135733.Mx1WAN7uo02QWK95NnY5_pbhj5x3V10YxXnreFmSaM0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27367@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27367#issuecomment-750311443
Comment:
No need to let these tests block the PR :)
```
diff --git a/srcpkgs/xfconf/template b/srcpkgs/xfconf/template
index 2d8924741c..2c712efd3e 100644
--- a/srcpkgs/xfconf/template
+++ b/srcpkgs/xfconf/template
@@ -7,6 +7,7 @@ build_style=gnu-configure
configure_args="--enable-gsettings-backend"
hostmakedepends="pkg-config intltool glib-devel vala-devel"
makedepends="libxfce4util-devel vala-devel"
+checkdepends="dbus xvfb-run"
short_desc="Xfce hierarchical (tree-like) configuration system"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-only, LGPL-2.0-only"
@@ -16,6 +17,10 @@ checksum=652a119007c67d9ba6c0bc7a740c923d33f32d03dc76dfc7ba682584e72a5425
build_options="gir"
build_options_default="gir"
+do_check() {
+ dbus-run-session xvfb-run make check
+}
+
xfconf-devel_package() {
depends="dbus-glib-devel ${sourcepkg}>=${version}_${revision}"
short_desc+=" - development files"
```
I would say the policy is to fix tests, if possible/simple. But we aren't blocking merges on complicated tests.
next prev parent reply other threads:[~2020-12-23 13:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 2:23 [PR PATCH] " pbui
2020-12-23 11:49 ` marmeladema
2020-12-23 13:43 ` pbui
2020-12-23 13:48 ` pbui
2020-12-23 13:57 ` ericonr [this message]
2020-12-23 14:17 ` [PR PATCH] [Updated] " pbui
2020-12-23 14:41 ` pbui
2020-12-23 14:46 ` sgn
2020-12-23 15:44 ` pbui
2020-12-23 16:07 ` pbui
2020-12-24 0:00 ` sgn
2020-12-24 0:06 ` sgn
2020-12-26 10:13 ` marmeladema
2020-12-26 11:29 ` sgn
2020-12-26 13:43 ` xfce4-4.16 pbui
2020-12-27 1:58 ` xfce4-4.16 sgn
2020-12-27 14:04 ` [PR PATCH] [Merged]: xfce4-4.16 sgn
2020-12-27 15:08 ` xfce4-4.16 sgn
2020-12-27 15:31 ` xfce4-4.16 sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223135733.Mx1WAN7uo02QWK95NnY5_pbhj5x3V10YxXnreFmSaM0@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).