New comment by mnabid on void-packages repository

https://github.com/void-linux/void-packages/pull/27416#issuecomment-751339005

Comment:
probably add a build_options and disable it by default.
________________________________
From: Đoàn Trần Công Danh <notifications@github.com>
Sent: Saturday, December 26, 2020 10:48 AM
To: void-linux/void-packages <void-packages@noreply.github.com>
Cc: Nafis <mnabid.25@outlook.com>; Mention <mention@noreply.github.com>
Subject: Re: [void-linux/void-packages] nautilus-python: fix cross-build (#27416)


@sgn commented on this pull request.

________________________________

In srcpkgs/nautilus-python/template<https://github.com/void-linux/void-packages/pull/27416#discussion_r548942955>:

> @@ -3,16 +3,17 @@ pkgname=nautilus-python
 version=1.2.3
 revision=3
 build_style=gnu-configure
-configure_args="--enable-gtk-doc PYTHON=python3"
-hostmakedepends="automake libtool pkg-config which"
-makedepends="python3-devel python3-gobject-devel gtk-doc nautilus-devel"
+configure_args="--disable-gtk-doc PYTHON=python3


When the configure_args changed, please bump revision.
@mnabid<https://github.com/mnabid> Do you still want to have gtk-doc? Should we add a build_options instead?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/void-linux/void-packages/pull/27416#pullrequestreview-558847069>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOZ5LGDX2S2ZRJJHP4A3QNLSWVTI3ANCNFSM4VIZGNBQ>.