From: newbluemoon <newbluemoon@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: 98-fixup-gir-path: ugly hack that needs to be fixed
Date: Sat, 26 Dec 2020 19:41:43 +0100 [thread overview]
Message-ID: <20201226184143.ntxA3MnGzWqL7TrEpeQWi8rd9wd4BDfprKXKp6h5SUk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27437@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]
New comment by newbluemoon on void-packages repository
https://github.com/void-linux/void-packages/issues/27437#issuecomment-751384475
Comment:
The culprit seems to be the `INTROSPECTION_GIRDIR` and `INTROSPECTION_TYPELIBDIR` variables in every `Makefile` which are set using the pkg-config-wrapper in `configure` via:
```
INTROSPECTION_GIRDIR=`$PKG_CONFIG --define-variable=datadir="${_GI_EXP_DATADIR}" --variable=girdir gobject-introspection-1.0`
INTROSPECTION_TYPELIBDIR="$($PKG_CONFIG --define-variable=libdir="${_GI_EXP_LIBDIR}" --variable=typelibdir gobject-introspection-1.0)"
```
which adds `$XBPS_CROSS_BASE`.
I don’t really have a solution, just a different hack: run
```
sed -e "s,^\(INTROSPECTION_GIRDIR\s*=\s*\)${XBPS_CROSS_BASE}\(.*\),\1\2," -i $(find . -name Makefile)
sed -e "s,^\(INTROSPECTION_TYPELIBDIR\s*=\s*\)${XBPS_CROSS_BASE}\(.*\),\1\2," -i $(find . -name Makefile)
```
between the `build` and `install` phase; either by replacing the hack in the `98-fixup-gir-path.sh`-hook or e.g. in a custom `pre_install()` (and removing the hook).
I haven’t tested if these variables are relevant for building the package, yet; if not then a clean solution could be adjusting the pkg-config-wrapper to not add `$XBPS_CROSS_BASE` to `girdir` and `typelibdir` queries.
next prev parent reply other threads:[~2020-12-26 18:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 3:27 [ISSUE] " pullmoll
2020-12-26 18:41 ` newbluemoon [this message]
2020-12-26 19:00 ` pullmoll
2020-12-26 19:29 ` pullmoll
2020-12-26 22:16 ` pullmoll
2020-12-27 13:55 ` pullmoll
2020-12-29 22:17 ` pullmoll
2020-12-29 22:17 ` pullmoll
2020-12-30 7:52 ` newbluemoon
2020-12-30 15:40 ` sgn
2020-12-30 15:44 ` newbluemoon
2020-12-30 16:42 ` ericonr
2020-12-30 16:56 ` pullmoll
2020-12-30 17:04 ` pullmoll
2020-12-30 23:38 ` sgn
2021-01-19 14:25 ` ericonr
2021-01-24 21:08 ` [ISSUE] [CLOSED] " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201226184143.ntxA3MnGzWqL7TrEpeQWi8rd9wd4BDfprKXKp6h5SUk@z \
--to=newbluemoon@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).