From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: guitarix2: update to 0.42.0 + added 'faust' build option
Date: Sun, 27 Dec 2020 01:57:24 +0100 [thread overview]
Message-ID: <20201227005724.EcBw5XriCSPQayS74I3P6plXNkYOo2hKWErXY-TfWmw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27420@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27420#issuecomment-751412541
Comment:
@DavideMaggio I was taking a look at how guitarix does its thing, it seems we shouldn't enable faust here.
They use it to generate a bunch of files, which are then post processed with some custom tools. Since they might have to fix those tools when using different faust versions, we risk breaking something by enabling faust. It's better to simply use their pre generated files directly, which is what we already do. From what I understand, guitarix doesn't use faust at runtime at all.
next prev parent reply other threads:[~2020-12-27 0:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 9:42 [PR PATCH] " DavideMaggio
2020-12-25 11:02 ` [PR PATCH] [Updated] " DavideMaggio
2020-12-26 5:04 ` ericonr
2020-12-26 8:01 ` [PR PATCH] [Updated] " DavideMaggio
2020-12-26 8:47 ` DavideMaggio
2020-12-26 9:49 ` DavideMaggio
2020-12-27 0:57 ` ericonr [this message]
2020-12-29 17:29 ` DavideMaggio
2020-12-29 21:18 ` ericonr
2020-12-31 8:09 ` [PR PATCH] [Updated] " DavideMaggio
2021-01-02 2:41 ` ericonr
2021-01-02 2:41 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201227005724.EcBw5XriCSPQayS74I3P6plXNkYOo2hKWErXY-TfWmw@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).