From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-dkimpy: update to 1.0.5
Date: Tue, 29 Dec 2020 16:04:17 +0100 [thread overview]
Message-ID: <20201229150417.qjMAam9QLlI0AtGbw2hF0f_Yu7yhY83cHcn2z1zRMJg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27431@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/27431#discussion_r549737236
Comment:
Why make this change? There is no need to break the build if this file disappears. Also, while you're editing this line, might as well make it
```bash
rm -f ${DESTDIR}/${py3_sitelib}/dkim/__main__.py
```
next prev parent reply other threads:[~2020-12-29 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 20:36 [PR PATCH] " paper42
2020-12-29 15:04 ` ahesford [this message]
2020-12-29 15:11 ` [PR REVIEW] " ericonr
2020-12-29 15:16 ` ahesford
2020-12-29 15:19 ` ericonr
2020-12-29 16:41 ` [PR PATCH] [Updated] " paper42
2020-12-29 16:42 ` [PR REVIEW] " paper42
2021-01-05 20:33 ` [PR PATCH] [Merged]: " Chocimier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201229150417.qjMAam9QLlI0AtGbw2hF0f_Yu7yhY83cHcn2z1zRMJg@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).