From: Johnnynator <Johnnynator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: catch2: update to 2.13.3.
Date: Thu, 31 Dec 2020 16:21:33 +0100 [thread overview]
Message-ID: <20201231152133.67Dfdm3nWcl3G2nOVDWIDsIjJuapvbg67XTg7M2tCQU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27364@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/27364#issuecomment-752986951
Comment:
They fail because `errno` on Musl and Glibc expand differently by one space.
```
xml.sw:
--- xml.sw.approved.txt
+++ xml.sw.unapproved.txt
- errno == 1
+ (*__errno_location()) == 1
****************************
Results differed
```
Can you add this patch and remove your `|| msg_warn`
```patch
--- scripts/approvalTests.py 2019-12-28 21:24:04.000000000 +0100
+++ - 2020-12-31 16:19:56.118506507 +0100
@@ -44,7 +44,7 @@
# errno macro expands into various names depending on platform, so we need to fix them up as well
errnoParser = re.compile(r'''
- \(\*__errno_location\ \(\)\)
+ \(\*__errno_location\s*\(\)\)
|
\(\*__error\(\)\)
|
```
next prev parent reply other threads:[~2020-12-31 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 22:55 [PR PATCH] " ndowens
2020-12-23 0:29 ` [PR PATCH] [Updated] " ndowens
2020-12-23 0:55 ` ndowens
2020-12-31 1:19 ` [PR PATCH] [Updated] " ndowens
2020-12-31 15:21 ` Johnnynator [this message]
2020-12-31 15:29 ` Johnnynator
2020-12-31 21:18 ` [PR PATCH] [Updated] " ndowens
2020-12-31 21:18 ` ndowens
2020-12-31 21:30 ` [PR PATCH] [Merged]: " ericonr
2020-12-31 22:58 ` ericonr
2021-01-01 1:04 ` ndowens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201231152133.67Dfdm3nWcl3G2nOVDWIDsIjJuapvbg67XTg7M2tCQU@z \
--to=johnnynator@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).