Github messages for voidlinux
 help / color / mirror / Atom feed
From: ndowens <ndowens@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] epson-inkjet-printer-escpr2: update to 1.1.24.
Date: Sat, 02 Jan 2021 02:20:56 +0100	[thread overview]
Message-ID: <20210102012056.vLJvBknvccgkTrmIw8p742ASmd3WWNJgXNRQQ8eN_Bc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27585@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New review comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/27585#discussion_r550828115

Comment:
It doesnt need to create it, it is already $pkgname-$version, but relooking at it, shouldnt even need to tell what wrksrc it is. Will re-verify, but as it was after update it was dir inside dir

  parent reply	other threads:[~2021-01-02  1:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-31 21:32 [PR PATCH] " ndowens
2020-12-31 21:32 ` [PR PATCH] [Updated] " ndowens
2021-01-02  1:01 ` [PR REVIEW] " ericonr
2021-01-02  1:20 ` ndowens [this message]
2021-01-05 21:44 ` Chocimier
2021-01-05 22:10 ` ndowens
2021-01-05 22:19 ` [PR PATCH] [Updated] " ndowens
2021-01-05 22:19 ` [PR REVIEW] " ndowens
2021-01-05 22:20 ` ndowens
2021-01-07 22:16 ` [PR PATCH] [Merged]: " Chocimier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210102012056.vLJvBknvccgkTrmIw8p742ASmd3WWNJgXNRQQ8eN_Bc@z \
    --to=ndowens@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).