* Re: gnucash: update to 4.3
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
@ 2020-12-28 19:53 ` unspecd
2020-12-29 21:37 ` [PR PATCH] [Updated] " manfredu
` (18 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: unspecd @ 2020-12-28 19:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 218 bytes --]
New comment by unspecd on void-packages repository
https://github.com/void-linux/void-packages/pull/27504#issuecomment-751844627
Comment:
https://github.com/void-linux/void-packages/pull/27320#issuecomment-751323377
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PR PATCH] [Updated] gnucash: update to 4.3
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
2020-12-28 19:53 ` unspecd
@ 2020-12-29 21:37 ` manfredu
2020-12-31 9:41 ` gnucash: update to 4.4 Hoshpak
` (17 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2020-12-29 21:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
There is an updated pull request by manfredu against master on the void-packages repository
https://github.com/manfredu/void-packages gnucash
https://github.com/void-linux/void-packages/pull/27504
gnucash: update to 4.3
A patch file from https://github.com/void-linux/void-packages/pull/27504.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnucash-27504.patch --]
[-- Type: text/x-diff, Size: 2487 bytes --]
From 39786d42c48062132ca0d32f79d49a163bc73640 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Mon, 28 Dec 2020 17:33:20 +0100
Subject: [PATCH 1/2] gnucash: update to 4.3
---
srcpkgs/gnucash/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 622b0ee6e3e..fdef279dc6b 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,7 +1,7 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.2
-revision=3
+version=4.3
+revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
@@ -14,9 +14,9 @@ short_desc="Financial-accounting software"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
-#distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
-distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=56d8ab039ef7784303ca9eab14bfc20f593f7a3f9b682a8a7eac25906a0d1308
+distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
+#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
+checksum=117e307deaf8de20b09f3aaa0036f6059131d482eaafa8094a1f8f450b75bcc4
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From 9a8295ae007cef9d83dc6c500a36bbe26cf32b62 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Tue, 29 Dec 2020 22:36:08 +0100
Subject: [PATCH 2/2] gnucash: update to 4.4
---
srcpkgs/gnucash/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index fdef279dc6b..400cd4c5f0b 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,6 +1,6 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.3
+version=4.4
revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
@@ -16,7 +16,7 @@ license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=117e307deaf8de20b09f3aaa0036f6059131d482eaafa8094a1f8f450b75bcc4
+checksum=d91e0d126b461d71de1bc1b20d9cf142704353dec07d3e6599d138422759e67a
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
2020-12-28 19:53 ` unspecd
2020-12-29 21:37 ` [PR PATCH] [Updated] " manfredu
@ 2020-12-31 9:41 ` Hoshpak
2021-01-02 13:13 ` manfredu
` (16 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: Hoshpak @ 2020-12-31 9:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
New comment by Hoshpak on void-packages repository
https://github.com/void-linux/void-packages/pull/27504#issuecomment-752904773
Comment:
The checks fail because they try to execute `make check` and it seems most of the test binaries are not available. To make them pass, it would be necessary to find out what is missing for the build process to build the tests and make sure they are compiled in the build process.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (2 preceding siblings ...)
2020-12-31 9:41 ` gnucash: update to 4.4 Hoshpak
@ 2021-01-02 13:13 ` manfredu
2021-01-03 5:51 ` fosslinux
` (15 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-01-02 13:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
New comment by manfredu on void-packages repository
https://github.com/void-linux/void-packages/pull/27504#issuecomment-753472149
Comment:
> The checks fail because they try to execute `make check` and it seems most of the test binaries are not available. To make them pass, it would be necessary to find out what is missing for the build process to build the tests and make sure they are compiled in the build process.
What does the third parameter in "Build packages (x86_64, x86_64, 1)" mean? For the builds where it is set to 0 the build succeeds.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (3 preceding siblings ...)
2021-01-02 13:13 ` manfredu
@ 2021-01-03 5:51 ` fosslinux
2021-01-03 10:40 ` manfredu
` (14 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: fosslinux @ 2021-01-03 5:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/27504#issuecomment-753572351
Comment:
The 1 means that tests are being run.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (4 preceding siblings ...)
2021-01-03 5:51 ` fosslinux
@ 2021-01-03 10:40 ` manfredu
2021-01-03 12:35 ` manfredu
` (13 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-01-03 10:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
New comment by manfredu on void-packages repository
https://github.com/void-linux/void-packages/pull/27504#issuecomment-753597670
Comment:
> The 1 means that tests are being run.
Thanks. So this explains why only those with 1 fail.
Can this pr still be processed?
Maybe some tests are failing because `make test` is used? Only `make check` builds and runs the full test suite. Some tests depend on additional libraries and the cmake built-in target test does not build them. Once the check target has been built check and test are synonyms.
Gnucash has got an automatic build and test bot on Travis CI to run the full test suite after every commit and for every Github pull request, so the released code should be fine despite
See https://wiki.gnucash.org/wiki/Testing.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (5 preceding siblings ...)
2021-01-03 10:40 ` manfredu
@ 2021-01-03 12:35 ` manfredu
2021-01-03 12:37 ` [PR PATCH] [Updated] " manfredu
` (12 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-01-03 12:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
New comment by manfredu on void-packages repository
https://github.com/void-linux/void-packages/pull/27504#issuecomment-753597670
Comment:
> The 1 means that tests are being run.
Thanks. So this explains why only those with 1 fail.
Can this pr still be processed?
Maybe some tests are failing because `make test` is used? Only `make check` builds and runs the full test suite. Some tests depend on additional libraries and the cmake built-in target test does not build them. Once the check target has been built check and test are synonyms.
Gnucash has got an automatic build and test bot on Travis CI to run the full test suite after every commit and for every Github pull request, so the released code should be fine anyway.
See https://wiki.gnucash.org/wiki/Testing.
I will try with `make_check_target=check`.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PR PATCH] [Updated] gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (6 preceding siblings ...)
2021-01-03 12:35 ` manfredu
@ 2021-01-03 12:37 ` manfredu
2021-01-03 12:45 ` [WIP] " manfredu
` (11 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-01-03 12:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
There is an updated pull request by manfredu against master on the void-packages repository
https://github.com/manfredu/void-packages gnucash
https://github.com/void-linux/void-packages/pull/27504
gnucash: update to 4.4
@Hoshpak: Could you pls have a look at this PR? I'm not sure what to do about the unsuccessful checks...
A patch file from https://github.com/void-linux/void-packages/pull/27504.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnucash-27504.patch --]
[-- Type: text/x-diff, Size: 3239 bytes --]
From 39786d42c48062132ca0d32f79d49a163bc73640 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Mon, 28 Dec 2020 17:33:20 +0100
Subject: [PATCH 1/3] gnucash: update to 4.3
---
srcpkgs/gnucash/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 622b0ee6e3e..fdef279dc6b 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,7 +1,7 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.2
-revision=3
+version=4.3
+revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
@@ -14,9 +14,9 @@ short_desc="Financial-accounting software"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
-#distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
-distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=56d8ab039ef7784303ca9eab14bfc20f593f7a3f9b682a8a7eac25906a0d1308
+distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
+#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
+checksum=117e307deaf8de20b09f3aaa0036f6059131d482eaafa8094a1f8f450b75bcc4
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From 9a8295ae007cef9d83dc6c500a36bbe26cf32b62 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Tue, 29 Dec 2020 22:36:08 +0100
Subject: [PATCH 2/3] gnucash: update to 4.4
---
srcpkgs/gnucash/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index fdef279dc6b..400cd4c5f0b 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,6 +1,6 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.3
+version=4.4
revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
@@ -16,7 +16,7 @@ license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=117e307deaf8de20b09f3aaa0036f6059131d482eaafa8094a1f8f450b75bcc4
+checksum=d91e0d126b461d71de1bc1b20d9cf142704353dec07d3e6599d138422759e67a
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From 5e7f53106cd60b67a8e87246eeef272f1a4ccdfe Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 3 Jan 2021 13:37:02 +0100
Subject: [PATCH 3/3] make_check_target=check
---
srcpkgs/gnucash/template | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 400cd4c5f0b..4bfa5eccfcc 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -4,6 +4,7 @@ version=4.4
revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
+make_check_target=check
configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
hostmakedepends="pkg-config guile python3 libxslt perl gettext swig"
makedepends="aqbanking-devel boost-devel gc-devel glib-devel gtest-devel guile-devel
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [WIP] gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (7 preceding siblings ...)
2021-01-03 12:37 ` [PR PATCH] [Updated] " manfredu
@ 2021-01-03 12:45 ` manfredu
2021-01-03 19:12 ` [PR PATCH] [Updated] " manfredu
` (10 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-01-03 12:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
New comment by manfredu on void-packages repository
https://github.com/void-linux/void-packages/pull/27504#issuecomment-753611797
Comment:
With `make_check_target=check` only 4 tests failed out of 111:
The following tests FAILED:
31 - test-qof (Subprocess aborted)
54 - test-gnc-numeric (Failed)
55 - test-gnc-timezone (Failed)
56 - test-gnc-datetime (Failed)
I will try to fix those as well, therefore I have set the PR to WIP.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PR PATCH] [Updated] [WIP] gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (8 preceding siblings ...)
2021-01-03 12:45 ` [WIP] " manfredu
@ 2021-01-03 19:12 ` manfredu
2021-01-03 19:19 ` manfredu
` (9 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-01-03 19:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
There is an updated pull request by manfredu against master on the void-packages repository
https://github.com/manfredu/void-packages gnucash
https://github.com/void-linux/void-packages/pull/27504
[WIP] gnucash: update to 4.4
@Hoshpak: Could you pls have a look at this PR? I'm not sure what to do about the unsuccessful checks...
A patch file from https://github.com/void-linux/void-packages/pull/27504.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnucash-27504.patch --]
[-- Type: text/x-diff, Size: 4224 bytes --]
From 39786d42c48062132ca0d32f79d49a163bc73640 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Mon, 28 Dec 2020 17:33:20 +0100
Subject: [PATCH 1/4] gnucash: update to 4.3
---
srcpkgs/gnucash/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 622b0ee6e3e..fdef279dc6b 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,7 +1,7 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.2
-revision=3
+version=4.3
+revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
@@ -14,9 +14,9 @@ short_desc="Financial-accounting software"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
-#distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
-distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=56d8ab039ef7784303ca9eab14bfc20f593f7a3f9b682a8a7eac25906a0d1308
+distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
+#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
+checksum=117e307deaf8de20b09f3aaa0036f6059131d482eaafa8094a1f8f450b75bcc4
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From 9a8295ae007cef9d83dc6c500a36bbe26cf32b62 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Tue, 29 Dec 2020 22:36:08 +0100
Subject: [PATCH 2/4] gnucash: update to 4.4
---
srcpkgs/gnucash/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index fdef279dc6b..400cd4c5f0b 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,6 +1,6 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.3
+version=4.4
revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
@@ -16,7 +16,7 @@ license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=117e307deaf8de20b09f3aaa0036f6059131d482eaafa8094a1f8f450b75bcc4
+checksum=d91e0d126b461d71de1bc1b20d9cf142704353dec07d3e6599d138422759e67a
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From 5e7f53106cd60b67a8e87246eeef272f1a4ccdfe Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 3 Jan 2021 13:37:02 +0100
Subject: [PATCH 3/4] make_check_target=check
---
srcpkgs/gnucash/template | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 400cd4c5f0b..4bfa5eccfcc 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -4,6 +4,7 @@ version=4.4
revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
+make_check_target=check
configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
hostmakedepends="pkg-config guile python3 libxslt perl gettext swig"
makedepends="aqbanking-devel boost-devel gc-devel glib-devel gtest-devel guile-devel
From 25a238ac33bc6cb53b0951000508d940c931a55a Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 3 Jan 2021 20:12:22 +0100
Subject: [PATCH 4/4] add tzdata as dependency
---
srcpkgs/gnucash/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 4bfa5eccfcc..ed1143d4817 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -9,7 +9,7 @@ configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
hostmakedepends="pkg-config guile python3 libxslt perl gettext swig"
makedepends="aqbanking-devel boost-devel gc-devel glib-devel gtest-devel guile-devel
gwenhywfar-devel ktoblzcheck-devel libofx-devel libsecret-devel
- libxslt-devel webkit2gtk-devel python3-devel gwenhywfar-gtk3"
+ libxslt-devel webkit2gtk-devel python3-devel gwenhywfar-gtk3 tzdata"
depends="dconf guile perl"
short_desc="Financial-accounting software"
maintainer="Orphaned <orphan@voidlinux.org>"
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [WIP] gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (9 preceding siblings ...)
2021-01-03 19:12 ` [PR PATCH] [Updated] " manfredu
@ 2021-01-03 19:19 ` manfredu
2021-01-03 23:22 ` fosslinux
` (8 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-01-03 19:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 422 bytes --]
New comment by manfredu on void-packages repository
https://github.com/void-linux/void-packages/pull/27504#issuecomment-753663954
Comment:
55 - test-gnc-timezone and
56 - test-gnc-datetime
no longer fail after adding tzdata as dependency.
The remaining failures appear to be down to not having the fr_FR and de_DE locales installed. The locales are needed only for testing, so imho this is ok now and ready to go.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (10 preceding siblings ...)
2021-01-03 19:19 ` manfredu
@ 2021-01-03 23:22 ` fosslinux
2021-02-04 22:13 ` [PR PATCH] [Updated] " manfredu
` (7 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: fosslinux @ 2021-01-03 23:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/27504#issuecomment-753691208
Comment:
You should either disable those two tests or else add `|| : # some comment indicating that the failures are due to lack of locales` to the end of the `make check` block to make the tests pass.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PR PATCH] [Updated] gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (11 preceding siblings ...)
2021-01-03 23:22 ` fosslinux
@ 2021-02-04 22:13 ` manfredu
2021-02-04 23:38 ` manfredu
` (6 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-02-04 22:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
There is an updated pull request by manfredu against master on the void-packages repository
https://github.com/manfredu/void-packages gnucash
https://github.com/void-linux/void-packages/pull/27504
gnucash: update to 4.4
@Hoshpak: Could you pls have a look at this PR? I'm not sure what to do about the unsuccessful checks...
A patch file from https://github.com/void-linux/void-packages/pull/27504.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnucash-27504.patch --]
[-- Type: text/x-diff, Size: 6447 bytes --]
From 3fdc11db450bfb8c54aae3d72d566afd4a77526a Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Mon, 28 Dec 2020 17:33:20 +0100
Subject: [PATCH 1/5] gnucash: update to 4.3
---
srcpkgs/gnucash/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 622b0ee6e3e..fdef279dc6b 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,7 +1,7 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.2
-revision=3
+version=4.3
+revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
@@ -14,9 +14,9 @@ short_desc="Financial-accounting software"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
-#distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
-distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=56d8ab039ef7784303ca9eab14bfc20f593f7a3f9b682a8a7eac25906a0d1308
+distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
+#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
+checksum=117e307deaf8de20b09f3aaa0036f6059131d482eaafa8094a1f8f450b75bcc4
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From 4918d5e9e913d6caf5fe31a32289e7243c8167e5 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Tue, 29 Dec 2020 22:36:08 +0100
Subject: [PATCH 2/5] gnucash: update to 4.4
---
srcpkgs/gnucash/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index fdef279dc6b..400cd4c5f0b 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,6 +1,6 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.3
+version=4.4
revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
@@ -16,7 +16,7 @@ license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=117e307deaf8de20b09f3aaa0036f6059131d482eaafa8094a1f8f450b75bcc4
+checksum=d91e0d126b461d71de1bc1b20d9cf142704353dec07d3e6599d138422759e67a
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From 81505cf618c6cb61f7aa3a38930c8d6601d2c02e Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 3 Jan 2021 13:37:02 +0100
Subject: [PATCH 3/5] make_check_target=check
---
srcpkgs/gnucash/template | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 400cd4c5f0b..4bfa5eccfcc 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -4,6 +4,7 @@ version=4.4
revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
+make_check_target=check
configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
hostmakedepends="pkg-config guile python3 libxslt perl gettext swig"
makedepends="aqbanking-devel boost-devel gc-devel glib-devel gtest-devel guile-devel
From 4ca32be32330c49fb22acb9a6d122b68397c5151 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 3 Jan 2021 20:12:22 +0100
Subject: [PATCH 4/5] add tzdata as dependency
---
srcpkgs/gnucash/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 4bfa5eccfcc..ed1143d4817 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -9,7 +9,7 @@ configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
hostmakedepends="pkg-config guile python3 libxslt perl gettext swig"
makedepends="aqbanking-devel boost-devel gc-devel glib-devel gtest-devel guile-devel
gwenhywfar-devel ktoblzcheck-devel libofx-devel libsecret-devel
- libxslt-devel webkit2gtk-devel python3-devel gwenhywfar-gtk3"
+ libxslt-devel webkit2gtk-devel python3-devel gwenhywfar-gtk3 tzdata"
depends="dconf guile perl"
short_desc="Financial-accounting software"
maintainer="Orphaned <orphan@voidlinux.org>"
From cb697053efef93a27f9fd88bf9af0e201ccda3b6 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Thu, 4 Feb 2021 23:07:12 +0100
Subject: [PATCH 5/5] Disable two tests which require having the fr_FR and
de_DE locales installed.
---
srcpkgs/gnucash/patches/disabletests.patch | 15 +++++++++++++++
srcpkgs/gnucash/template | 1 +
2 files changed, 16 insertions(+)
create mode 100644 srcpkgs/gnucash/patches/disabletests.patch
diff --git a/srcpkgs/gnucash/patches/disabletests.patch b/srcpkgs/gnucash/patches/disabletests.patch
new file mode 100644
index 00000000000..b17be791693
--- /dev/null
+++ b/srcpkgs/gnucash/patches/disabletests.patch
@@ -0,0 +1,15 @@
+diff -Naurp0 a/libgnucash/engine/test/CMakeLists.txt b/libgnucash/engine/test/CMakeLists.txt
+--- libgnucash/engine/test/CMakeLists.txt 2020-07-11 01:39:03.000000000 +0200
++++ libgnucash/engine/test/CMakeLists.txt 2021-01-31 22:22:19.782029671 +0100
+@@ -49,3 +49,3 @@ if (NOT WIN32)
+- set(SOURCES ${test_qof_SOURCES} ${CMAKE_SOURCE_DIR}/common/test-core/unittest-support.c)
+- add_engine_test(test-qof "${SOURCES}")
+- target_compile_definitions(test-qof PRIVATE TESTPROG=test_qof)
++ # set(SOURCES ${test_qof_SOURCES} ${CMAKE_SOURCE_DIR}/common/test-core/unittest-support.c)
++ # add_engine_test(test-qof "${SOURCES}")
++ # target_compile_definitions(test-qof PRIVATE TESTPROG=test_qof)
+@@ -167,2 +167,2 @@ set(test_gnc_numeric_SOURCES
+-gnc_add_test(test-gnc-numeric "${test_gnc_numeric_SOURCES}"
+- gtest_engine_INCLUDES gtest_qof_LIBS)
++# gnc_add_test(test-gnc-numeric "${test_gnc_numeric_SOURCES}"
++# gtest_engine_INCLUDES gtest_qof_LIBS)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index ed1143d4817..0d08699ea7a 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -18,6 +18,7 @@ homepage="http://www.gnucash.org"
distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
checksum=d91e0d126b461d71de1bc1b20d9cf142704353dec07d3e6599d138422759e67a
+patch_args="-Np1"
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PR PATCH] [Updated] gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (12 preceding siblings ...)
2021-02-04 22:13 ` [PR PATCH] [Updated] " manfredu
@ 2021-02-04 23:38 ` manfredu
2021-02-06 19:04 ` manfredu
` (5 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-02-04 23:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
There is an updated pull request by manfredu against master on the void-packages repository
https://github.com/manfredu/void-packages gnucash
https://github.com/void-linux/void-packages/pull/27504
gnucash: update to 4.4
@Hoshpak: Could you pls have a look at this PR? I'm not sure what to do about the unsuccessful checks...
A patch file from https://github.com/void-linux/void-packages/pull/27504.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnucash-27504.patch --]
[-- Type: text/x-diff, Size: 5741 bytes --]
From bf367ce5c9e63197126c1f51e73fa6c1f2b6c6ab Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Mon, 28 Dec 2020 17:33:20 +0100
Subject: [PATCH 1/5] gnucash: update to 4.3
---
srcpkgs/gnucash/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 622b0ee6e3e..fdef279dc6b 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,7 +1,7 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.2
-revision=3
+version=4.3
+revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
@@ -14,9 +14,9 @@ short_desc="Financial-accounting software"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
-#distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
-distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=56d8ab039ef7784303ca9eab14bfc20f593f7a3f9b682a8a7eac25906a0d1308
+distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
+#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
+checksum=117e307deaf8de20b09f3aaa0036f6059131d482eaafa8094a1f8f450b75bcc4
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From cb82c26d9adb4745bc8307cef41e9b5f09fd1670 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Tue, 29 Dec 2020 22:36:08 +0100
Subject: [PATCH 2/5] gnucash: update to 4.4
---
srcpkgs/gnucash/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index fdef279dc6b..400cd4c5f0b 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,6 +1,6 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.3
+version=4.4
revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
@@ -16,7 +16,7 @@ license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=117e307deaf8de20b09f3aaa0036f6059131d482eaafa8094a1f8f450b75bcc4
+checksum=d91e0d126b461d71de1bc1b20d9cf142704353dec07d3e6599d138422759e67a
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From f88c3036c83aee7396c5fbbb7c37d4c872c63cdd Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 3 Jan 2021 13:37:02 +0100
Subject: [PATCH 3/5] make_check_target=check
---
srcpkgs/gnucash/template | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 400cd4c5f0b..4bfa5eccfcc 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -4,6 +4,7 @@ version=4.4
revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
+make_check_target=check
configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
hostmakedepends="pkg-config guile python3 libxslt perl gettext swig"
makedepends="aqbanking-devel boost-devel gc-devel glib-devel gtest-devel guile-devel
From daaae5d4e64c492e6f372014a5d2fa65df927dcb Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 3 Jan 2021 20:12:22 +0100
Subject: [PATCH 4/5] add tzdata as dependency
---
srcpkgs/gnucash/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 4bfa5eccfcc..ed1143d4817 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -9,7 +9,7 @@ configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
hostmakedepends="pkg-config guile python3 libxslt perl gettext swig"
makedepends="aqbanking-devel boost-devel gc-devel glib-devel gtest-devel guile-devel
gwenhywfar-devel ktoblzcheck-devel libofx-devel libsecret-devel
- libxslt-devel webkit2gtk-devel python3-devel gwenhywfar-gtk3"
+ libxslt-devel webkit2gtk-devel python3-devel gwenhywfar-gtk3 tzdata"
depends="dconf guile perl"
short_desc="Financial-accounting software"
maintainer="Orphaned <orphan@voidlinux.org>"
From 6de80cf5a588ed9427eccc30eab38478e8dc071f Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Thu, 4 Feb 2021 23:07:12 +0100
Subject: [PATCH 5/5] Disable two tests which require having the fr_FR and
de_DE locales installed.
---
srcpkgs/gnucash/patches/disabletests.patch | 14 ++++++++++++++
1 file changed, 14 insertions(+)
create mode 100644 srcpkgs/gnucash/patches/disabletests.patch
diff --git a/srcpkgs/gnucash/patches/disabletests.patch b/srcpkgs/gnucash/patches/disabletests.patch
new file mode 100644
index 00000000000..fe18e21f1f1
--- /dev/null
+++ b/srcpkgs/gnucash/patches/disabletests.patch
@@ -0,0 +1,14 @@
+--- libgnucash/engine/test/CMakeLists.txt 2020-07-11 01:39:03.000000000 +0200
++++ libgnucash/engine/test/CMakeLists.txt 2021-01-31 22:22:19.782029671 +0100
+@@ -49,3 +49,3 @@ if (NOT WIN32)
+- set(SOURCES ${test_qof_SOURCES} ${CMAKE_SOURCE_DIR}/common/test-core/unittest-support.c)
+- add_engine_test(test-qof "${SOURCES}")
+- target_compile_definitions(test-qof PRIVATE TESTPROG=test_qof)
++ # set(SOURCES ${test_qof_SOURCES} ${CMAKE_SOURCE_DIR}/common/test-core/unittest-support.c)
++ # add_engine_test(test-qof "${SOURCES}")
++ # target_compile_definitions(test-qof PRIVATE TESTPROG=test_qof)
+@@ -167,2 +167,2 @@ set(test_gnc_numeric_SOURCES
+-gnc_add_test(test-gnc-numeric "${test_gnc_numeric_SOURCES}"
+- gtest_engine_INCLUDES gtest_qof_LIBS)
++# gnc_add_test(test-gnc-numeric "${test_gnc_numeric_SOURCES}"
++# gtest_engine_INCLUDES gtest_qof_LIBS)
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PR PATCH] [Updated] gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (13 preceding siblings ...)
2021-02-04 23:38 ` manfredu
@ 2021-02-06 19:04 ` manfredu
2021-02-06 23:02 ` manfredu
` (4 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-02-06 19:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
There is an updated pull request by manfredu against master on the void-packages repository
https://github.com/manfredu/void-packages gnucash
https://github.com/void-linux/void-packages/pull/27504
gnucash: update to 4.4
@Hoshpak: Could you pls have a look at this PR? I'm not sure what to do about the unsuccessful checks...
A patch file from https://github.com/void-linux/void-packages/pull/27504.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnucash-27504.patch --]
[-- Type: text/x-diff, Size: 7333 bytes --]
From a841d1b2030c55473cddd13af157aedf20ac7749 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Mon, 28 Dec 2020 17:33:20 +0100
Subject: [PATCH 1/6] gnucash: update to 4.3
---
srcpkgs/gnucash/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 622b0ee6e3e..fdef279dc6b 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,7 +1,7 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.2
-revision=3
+version=4.3
+revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
@@ -14,9 +14,9 @@ short_desc="Financial-accounting software"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
-#distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
-distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=56d8ab039ef7784303ca9eab14bfc20f593f7a3f9b682a8a7eac25906a0d1308
+distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
+#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
+checksum=117e307deaf8de20b09f3aaa0036f6059131d482eaafa8094a1f8f450b75bcc4
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From d87e94bb917482727d0e1b34c745cd05a6e181af Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Tue, 29 Dec 2020 22:36:08 +0100
Subject: [PATCH 2/6] gnucash: update to 4.4
---
srcpkgs/gnucash/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index fdef279dc6b..400cd4c5f0b 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,6 +1,6 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.3
+version=4.4
revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
@@ -16,7 +16,7 @@ license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=117e307deaf8de20b09f3aaa0036f6059131d482eaafa8094a1f8f450b75bcc4
+checksum=d91e0d126b461d71de1bc1b20d9cf142704353dec07d3e6599d138422759e67a
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From b3b54bd0ae5439289d14776c06c7958b41a25bdb Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 3 Jan 2021 13:37:02 +0100
Subject: [PATCH 3/6] make_check_target=check
---
srcpkgs/gnucash/template | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 400cd4c5f0b..4bfa5eccfcc 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -4,6 +4,7 @@ version=4.4
revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
+make_check_target=check
configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
hostmakedepends="pkg-config guile python3 libxslt perl gettext swig"
makedepends="aqbanking-devel boost-devel gc-devel glib-devel gtest-devel guile-devel
From 1d31ce38623c1a2a384eb6dd58a26f73fbe1fd22 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 3 Jan 2021 20:12:22 +0100
Subject: [PATCH 4/6] add tzdata as dependency
---
srcpkgs/gnucash/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 4bfa5eccfcc..ed1143d4817 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -9,7 +9,7 @@ configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
hostmakedepends="pkg-config guile python3 libxslt perl gettext swig"
makedepends="aqbanking-devel boost-devel gc-devel glib-devel gtest-devel guile-devel
gwenhywfar-devel ktoblzcheck-devel libofx-devel libsecret-devel
- libxslt-devel webkit2gtk-devel python3-devel gwenhywfar-gtk3"
+ libxslt-devel webkit2gtk-devel python3-devel gwenhywfar-gtk3 tzdata"
depends="dconf guile perl"
short_desc="Financial-accounting software"
maintainer="Orphaned <orphan@voidlinux.org>"
From 7be72d5302512cafce84d69a6bf4466aa067eab5 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Thu, 4 Feb 2021 23:07:12 +0100
Subject: [PATCH 5/6] Disable two tests which require having the fr_FR and
de_DE locales installed.
---
srcpkgs/gnucash/patches/disabletests.patch | 14 ++++++++++++++
1 file changed, 14 insertions(+)
create mode 100644 srcpkgs/gnucash/patches/disabletests.patch
diff --git a/srcpkgs/gnucash/patches/disabletests.patch b/srcpkgs/gnucash/patches/disabletests.patch
new file mode 100644
index 00000000000..fe18e21f1f1
--- /dev/null
+++ b/srcpkgs/gnucash/patches/disabletests.patch
@@ -0,0 +1,14 @@
+--- libgnucash/engine/test/CMakeLists.txt 2020-07-11 01:39:03.000000000 +0200
++++ libgnucash/engine/test/CMakeLists.txt 2021-01-31 22:22:19.782029671 +0100
+@@ -49,3 +49,3 @@ if (NOT WIN32)
+- set(SOURCES ${test_qof_SOURCES} ${CMAKE_SOURCE_DIR}/common/test-core/unittest-support.c)
+- add_engine_test(test-qof "${SOURCES}")
+- target_compile_definitions(test-qof PRIVATE TESTPROG=test_qof)
++ # set(SOURCES ${test_qof_SOURCES} ${CMAKE_SOURCE_DIR}/common/test-core/unittest-support.c)
++ # add_engine_test(test-qof "${SOURCES}")
++ # target_compile_definitions(test-qof PRIVATE TESTPROG=test_qof)
+@@ -167,2 +167,2 @@ set(test_gnc_numeric_SOURCES
+-gnc_add_test(test-gnc-numeric "${test_gnc_numeric_SOURCES}"
+- gtest_engine_INCLUDES gtest_qof_LIBS)
++# gnc_add_test(test-gnc-numeric "${test_gnc_numeric_SOURCES}"
++# gtest_engine_INCLUDES gtest_qof_LIBS)
From dd100c07be7c5cb60399ea6cb8be13b499e1b56e Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sat, 6 Feb 2021 20:03:01 +0100
Subject: [PATCH 6/6] Fix use-after-free in test_xaccTransEqual
---
srcpkgs/gnucash/patches/fixtest.patch | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 srcpkgs/gnucash/patches/fixtest.patch
diff --git a/srcpkgs/gnucash/patches/fixtest.patch b/srcpkgs/gnucash/patches/fixtest.patch
new file mode 100644
index 00000000000..4404d99a534
--- /dev/null
+++ b/srcpkgs/gnucash/patches/fixtest.patch
@@ -0,0 +1,17 @@
+--- libgnucash/engine/test/utest-Transaction.cpp
++++ libgnucash/engine/test/utest-Transaction.cpp
+@@ -901,7 +901,6 @@ test_xaccTransEqual (Fixture *fixture, gconstpointer pData)
+ g_assert_cmpint (check->hits, ==, 10);
+ g_assert_cmpint (check2->hits, ==, 1);
+
+- g_free (check->msg);
+ g_free (check2->msg);
+ check2->msg = g_strdup_printf (
+ "[xaccTransEqual] splits %s and %s differ", split_guid0, split_guid0);
+@@ -924,6 +923,7 @@ test_xaccTransEqual (Fixture *fixture, gconstpointer pData)
+ auto bal01 = gnc_numeric_to_string (split01->balance);
+ auto bal10 = gnc_numeric_to_string (split10->balance);
+ auto bal11 = gnc_numeric_to_string (split11->balance);
++ g_free (check->msg);
+ check->msg = g_strdup_printf("[xaccSplitEqualCheckBal] balances differ: %s vs %s", bal10, bal00);
+ check3->msg = g_strdup_printf("[xaccSplitEqualCheckBal] balances differ: %s vs %s", bal11, bal01);
\ No newline at end of file
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (14 preceding siblings ...)
2021-02-06 19:04 ` manfredu
@ 2021-02-06 23:02 ` manfredu
2021-02-06 23:04 ` pullmoll
` (3 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-02-06 23:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
New comment by manfredu on void-packages repository
https://github.com/void-linux/void-packages/pull/27504#issuecomment-774556511
Comment:
@Hoshpak Could somebody pls review this PR and merge, if possible? Thanks! :-)
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (15 preceding siblings ...)
2021-02-06 23:02 ` manfredu
@ 2021-02-06 23:04 ` pullmoll
2021-02-06 23:28 ` [PR PATCH] [Updated] " manfredu
` (2 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: pullmoll @ 2021-02-06 23:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 164 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/27504#issuecomment-774556778
Comment:
Please squash commits.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PR PATCH] [Updated] gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (16 preceding siblings ...)
2021-02-06 23:04 ` pullmoll
@ 2021-02-06 23:28 ` manfredu
2021-02-06 23:50 ` manfredu
2021-02-07 10:27 ` [PR PATCH] [Merged]: " Hoshpak
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-02-06 23:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
There is an updated pull request by manfredu against master on the void-packages repository
https://github.com/manfredu/void-packages gnucash
https://github.com/void-linux/void-packages/pull/27504
gnucash: update to 4.4
@Hoshpak: Could you pls have a look at this PR? I'm not sure what to do about the unsuccessful checks...
A patch file from https://github.com/void-linux/void-packages/pull/27504.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnucash-27504.patch --]
[-- Type: text/x-diff, Size: 4554 bytes --]
From 5be7e0bb0ea4888355fea9c3fe56d317e9f3d284 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sat, 6 Feb 2021 20:03:01 +0100
Subject: [PATCH] gnucash: update to 4.4
Fix use-after-free in test_xaccTransEqual
Disable two tests which require having the fr_FR and de_DE locales installed.
Add tzdata as dependency
Make_check_target=check
---
srcpkgs/gnucash/patches/disabletests.patch | 14 ++++++++++++++
srcpkgs/gnucash/patches/fixtest.patch | 17 +++++++++++++++++
srcpkgs/gnucash/template | 13 +++++++------
3 files changed, 38 insertions(+), 6 deletions(-)
create mode 100644 srcpkgs/gnucash/patches/disabletests.patch
create mode 100644 srcpkgs/gnucash/patches/fixtest.patch
diff --git a/srcpkgs/gnucash/patches/disabletests.patch b/srcpkgs/gnucash/patches/disabletests.patch
new file mode 100644
index 00000000000..fe18e21f1f1
--- /dev/null
+++ b/srcpkgs/gnucash/patches/disabletests.patch
@@ -0,0 +1,14 @@
+--- libgnucash/engine/test/CMakeLists.txt 2020-07-11 01:39:03.000000000 +0200
++++ libgnucash/engine/test/CMakeLists.txt 2021-01-31 22:22:19.782029671 +0100
+@@ -49,3 +49,3 @@ if (NOT WIN32)
+- set(SOURCES ${test_qof_SOURCES} ${CMAKE_SOURCE_DIR}/common/test-core/unittest-support.c)
+- add_engine_test(test-qof "${SOURCES}")
+- target_compile_definitions(test-qof PRIVATE TESTPROG=test_qof)
++ # set(SOURCES ${test_qof_SOURCES} ${CMAKE_SOURCE_DIR}/common/test-core/unittest-support.c)
++ # add_engine_test(test-qof "${SOURCES}")
++ # target_compile_definitions(test-qof PRIVATE TESTPROG=test_qof)
+@@ -167,2 +167,2 @@ set(test_gnc_numeric_SOURCES
+-gnc_add_test(test-gnc-numeric "${test_gnc_numeric_SOURCES}"
+- gtest_engine_INCLUDES gtest_qof_LIBS)
++# gnc_add_test(test-gnc-numeric "${test_gnc_numeric_SOURCES}"
++# gtest_engine_INCLUDES gtest_qof_LIBS)
diff --git a/srcpkgs/gnucash/patches/fixtest.patch b/srcpkgs/gnucash/patches/fixtest.patch
new file mode 100644
index 00000000000..4404d99a534
--- /dev/null
+++ b/srcpkgs/gnucash/patches/fixtest.patch
@@ -0,0 +1,17 @@
+--- libgnucash/engine/test/utest-Transaction.cpp
++++ libgnucash/engine/test/utest-Transaction.cpp
+@@ -901,7 +901,6 @@ test_xaccTransEqual (Fixture *fixture, gconstpointer pData)
+ g_assert_cmpint (check->hits, ==, 10);
+ g_assert_cmpint (check2->hits, ==, 1);
+
+- g_free (check->msg);
+ g_free (check2->msg);
+ check2->msg = g_strdup_printf (
+ "[xaccTransEqual] splits %s and %s differ", split_guid0, split_guid0);
+@@ -924,6 +923,7 @@ test_xaccTransEqual (Fixture *fixture, gconstpointer pData)
+ auto bal01 = gnc_numeric_to_string (split01->balance);
+ auto bal10 = gnc_numeric_to_string (split10->balance);
+ auto bal11 = gnc_numeric_to_string (split11->balance);
++ g_free (check->msg);
+ check->msg = g_strdup_printf("[xaccSplitEqualCheckBal] balances differ: %s vs %s", bal10, bal00);
+ check3->msg = g_strdup_printf("[xaccSplitEqualCheckBal] balances differ: %s vs %s", bal11, bal01);
\ No newline at end of file
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 622b0ee6e3e..ed1143d4817 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,22 +1,23 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=4.2
-revision=3
+version=4.4
+revision=1
wrksrc="${pkgname}-${version%b}"
build_style=cmake
+make_check_target=check
configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
hostmakedepends="pkg-config guile python3 libxslt perl gettext swig"
makedepends="aqbanking-devel boost-devel gc-devel glib-devel gtest-devel guile-devel
gwenhywfar-devel ktoblzcheck-devel libofx-devel libsecret-devel
- libxslt-devel webkit2gtk-devel python3-devel gwenhywfar-gtk3"
+ libxslt-devel webkit2gtk-devel python3-devel gwenhywfar-gtk3 tzdata"
depends="dconf guile perl"
short_desc="Financial-accounting software"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
-#distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
-distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=56d8ab039ef7784303ca9eab14bfc20f593f7a3f9b682a8a7eac25906a0d1308
+distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
+#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
+checksum=d91e0d126b461d71de1bc1b20d9cf142704353dec07d3e6599d138422759e67a
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (17 preceding siblings ...)
2021-02-06 23:28 ` [PR PATCH] [Updated] " manfredu
@ 2021-02-06 23:50 ` manfredu
2021-02-07 10:27 ` [PR PATCH] [Merged]: " Hoshpak
19 siblings, 0 replies; 21+ messages in thread
From: manfredu @ 2021-02-06 23:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
New comment by manfredu on void-packages repository
https://github.com/void-linux/void-packages/pull/27504#issuecomment-774561666
Comment:
> Please squash commits.
Done.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PR PATCH] [Merged]: gnucash: update to 4.4
2020-12-28 16:34 [PR PATCH] gnucash: update to 4.3 manfredu
` (18 preceding siblings ...)
2021-02-06 23:50 ` manfredu
@ 2021-02-07 10:27 ` Hoshpak
19 siblings, 0 replies; 21+ messages in thread
From: Hoshpak @ 2021-02-07 10:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
There's a merged pull request on the void-packages repository
gnucash: update to 4.4
https://github.com/void-linux/void-packages/pull/27504
Description:
@Hoshpak: Could you pls have a look at this PR? I'm not sure what to do about the unsuccessful checks...
^ permalink raw reply [flat|nested] 21+ messages in thread