From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: fceux: update to 2.3.0.
Date: Sun, 03 Jan 2021 21:54:29 +0100 [thread overview]
Message-ID: <20210103205429.Pe3_YW6LQb3HPyxUCq55mTjE0Q2CrhHznhgb3wQFcqQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27646@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27646#issuecomment-753674759
Comment:
```
/builddir/fceux-fceux-2.3.0/src/drivers/Qt/HexEditor.cpp:2171:11: error: expected id-expression before '(' token
2171 | if ( ::isascii( key ) )
```
C standard allows `isascii` (or any functions from ctype.h) to be a macro as well as a function, so using the name here is wrong. Easiest solution is adding `#undef isascii` to the top of the file, best solution is not including `ctype.h` at all (if possible).
next prev parent reply other threads:[~2021-01-03 20:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 20:41 [PR PATCH] " CameronNemo
2021-01-03 20:54 ` ericonr [this message]
2021-01-03 21:09 ` ericonr
2021-01-05 2:36 ` ericonr
2021-02-15 4:37 ` [PR PATCH] [Closed]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210103205429.Pe3_YW6LQb3HPyxUCq55mTjE0Q2CrhHznhgb3wQFcqQ@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).