From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] exo: Add proper cross patch
Date: Mon, 04 Jan 2021 17:51:47 +0100 [thread overview]
Message-ID: <20210104165147.XVnhdahVJUA84tp0MPC9KoAllt3qGVHJhy-scgAaBDk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27661@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/27661#discussion_r551438022
Comment:
Please try to understand what does this check do before trying to patch it.
The current patch is correctly asking for some cached value which we know.
The new patch unconditionally defines `ac_cv_strftime_extensions=yes`, which is incorrect.
next prev parent reply other threads:[~2021-01-04 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 16:44 [PR PATCH] " ndowens
2021-01-04 16:51 ` sgn [this message]
2021-01-04 16:52 ` [PR PATCH] [Closed]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104165147.XVnhdahVJUA84tp0MPC9KoAllt3qGVHJhy-scgAaBDk@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).