Re: [PR PATCH] [Updated] slack-desktop: add -p to mkdir to avoid error

[acobaugh <acobaugh@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

There is an updated pull request by acobaugh against master on the void-packages repository

https://github.com/acobaugh/void-packages master
https://github.com/void-linux/void-packages/pull/27663

slack-desktop: add -p to mkdir to avoid error
I encountered this error when attempting to build slack-desktop locally. Unsure if there's a better fix, but it seems harmless.

```
=> slack-desktop-4.12.0_1: running do_install ...
mkdir: cannot create directory ‘/destdir//slack-desktop-4.12.0/usr/lib’: File exists
=> ERROR: slack-desktop-4.12.0_1: do_install: 'mkdir ${DESTDIR}/usr/{bin,lib}' exited with 1
=> ERROR:   in do_install() at srcpkgs/slack-desktop/template:27
```

A patch file from https://github.com/void-linux/void-packages/pull/27663.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-27663.patch --]
[-- Type: text/x-diff, Size: 2543 bytes --]

From 017a6906d382cece720bbb42d42c24623d28097f Mon Sep 17 00:00:00 2001
From: Andy Cobaugh <andrew.cobaugh@gmail.com>
Date: Mon, 4 Jan 2021 12:12:31 -0500
Subject: [PATCH 1/3] slack-desktop: add -p to mkdir to avoid error

---
 srcpkgs/slack-desktop/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/slack-desktop/template b/srcpkgs/slack-desktop/template
index 9eda6c37e60..e64807863c1 100644
--- a/srcpkgs/slack-desktop/template
+++ b/srcpkgs/slack-desktop/template
@@ -24,7 +24,7 @@ do_install() {
 	vlicense usr/share/doc/slack-desktop/copyright
 	vinstall usr/share/applications/slack.desktop 644 usr/share/applications
 	vinstall usr/share/pixmaps/slack.png 644 usr/share/pixmaps
-	mkdir ${DESTDIR}/usr/{bin,lib}
+	mkdir -p ${DESTDIR}/usr/{bin,lib}
 	vcopy usr/lib/slack usr/lib
 	ln -s ../lib/slack/slack ${DESTDIR}/usr/bin/slack
 }

From a7c781993ec71c3764c3a4cda832b8e786517514 Mon Sep 17 00:00:00 2001
From: Andy Cobaugh <andrew.cobaugh@gmail.com>
Date: Mon, 4 Jan 2021 15:58:56 -0500
Subject: [PATCH 2/3] textadept: remove superfluous mkdir

---
 srcpkgs/textadept/template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/textadept/template b/srcpkgs/textadept/template
index 405af9460de..6078875b1d8 100644
--- a/srcpkgs/textadept/template
+++ b/srcpkgs/textadept/template
@@ -76,7 +76,6 @@ do_install() {
 
 	# Binaries in /usr/share/textadept are not allowed
 	# So we relocate to /usr/lib/textadept
-	mkdir -p "${DESTDIR}/usr/lib/"
 	mv "${DESTDIR}/usr/share/textadept" "${DESTDIR}/usr/lib/textadept"
 	ln -sf "/usr/lib/textadept/textadept" "${DESTDIR}/usr/bin/textadept"
 	ln -sf "/usr/lib/textadept/textadept-curses" \

From 5e6a1ec714eb271d977c061397bd392e285171e2 Mon Sep 17 00:00:00 2001
From: Andy Cobaugh <andrew.cobaugh@gmail.com>
Date: Mon, 4 Jan 2021 16:05:11 -0500
Subject: [PATCH 3/3] slack-desktop: remove mkdir of usr/lib

---
 srcpkgs/slack-desktop/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/slack-desktop/template b/srcpkgs/slack-desktop/template
index e64807863c1..a0c55ec0c28 100644
--- a/srcpkgs/slack-desktop/template
+++ b/srcpkgs/slack-desktop/template
@@ -24,7 +24,7 @@ do_install() {
 	vlicense usr/share/doc/slack-desktop/copyright
 	vinstall usr/share/applications/slack.desktop 644 usr/share/applications
 	vinstall usr/share/pixmaps/slack.png 644 usr/share/pixmaps
-	mkdir -p ${DESTDIR}/usr/{bin,lib}
+	mkdir ${DESTDIR}/usr/bin
 	vcopy usr/lib/slack usr/lib
 	ln -s ../lib/slack/slack ${DESTDIR}/usr/bin/slack
 }