Github messages for voidlinux
 help / color / mirror / Atom feed
From: AluminumTank <AluminumTank@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: nginx: build with http_slice_module
Date: Tue, 05 Jan 2021 15:16:14 +0100	[thread overview]
Message-ID: <20210105141614.Zuq08MCljEg8ugT69ZW73COnZPfXS1MJagMmERXFRas@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27662@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

New comment by AluminumTank on void-packages repository

https://github.com/void-linux/void-packages/pull/27662#issuecomment-754661853

Comment:
I don't think that just because the documentation says it doesn't build by default, we shouldn't have it in our build.

A good example of this is the [SSL module](http://nginx.org/en/docs/http/ngx_http_ssl_module.html), which is not included in the default build. Should Void not include SSL either since it's not default? 

For reference, one of my nginx server blocks uses slice, which is why I'm here. Anecdotally, the build instructions for the package providing this server block config didn't even mention that nginx needs to be built with slice support, so the status quo is that this is a "default" module.

There is likely no easy way to get slice (or other module) support without manually recompiling. The only way I saw was to use dynamic modules, but this requires grabbing the source code for the version of nginx currently on your machine, compiling the modules as dynamic objects, and adding them into the nginx config. This would cause breakage or additional work when the nginx version that Void distributes gets bumped.

Other distributions include this module in their builds as well (I just looked at the PKGBUILD for Arch and ebuild for Gentoo). 

The other option is to package the modules separately as dynamic modules as mentioned above, which I'd be happy to do if this is a better solution.

  parent reply	other threads:[~2021-01-05 14:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 17:24 [PR PATCH] " AluminumTank
2021-01-04 17:47 ` [PR REVIEW] " ericonr
2021-01-04 18:13 ` [PR PATCH] [Updated] " AluminumTank
2021-01-04 19:33 ` Duncaen
2021-01-05  3:45 ` [PR PATCH] [Updated] " AluminumTank
2021-01-05 14:16 ` AluminumTank [this message]
2021-01-22  4:34 ` ericonr
2021-02-15  4:05 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210105141614.Zuq08MCljEg8ugT69ZW73COnZPfXS1MJagMmERXFRas@z \
    --to=aluminumtank@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).