Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: qhull: update to 2020.2
Date: Wed, 06 Jan 2021 17:34:09 +0100	[thread overview]
Message-ID: <20210106163409.k_brdjb1t4NlMWteUdRQ3HsPhlGVX6jIYcPUyHQXHKs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27082@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/27082#issuecomment-755411270

Comment:
I have rolled this into some other updates and will merge soon. The `python3-matplotlib` tests are problematic for several reasons:
- The `PYTHONPATH` would need to be set to find compiled extensions, which is the source of the failure here.
- If you set `PYTHONPATH` to include `build/lib*` where the compiled extensions are, the `matplotlib` module does not include the baseline images needed for the tests.
- Copying the shared objects from `build/lib*` to the corresponding directories of `lib` and setting `PYTHONPATH=lib` allows the tests to run.

Unfortunately, `matplotlib` tests are evaluated by comparing output images to baseline images produced upstream, which is incredibly fragile because of differences in fonts and layout. Just disabling the tests is the right thing to do here.

Of course, if you're disabling tests, there is no value in pulling in `checkdepends`, so I've dropped that change.

  parent reply	other threads:[~2021-01-06 16:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 19:34 [PR PATCH] " olafmersmann
2020-12-10 19:38 ` [PR PATCH] [Updated] " olafmersmann
2020-12-10 21:25 ` olafmersmann
2020-12-10 21:29 ` olafmersmann
2020-12-14 12:12 ` olafmersmann
2020-12-14 12:15 ` olafmersmann
2020-12-14 14:22 ` olafmersmann
2020-12-14 14:22 ` olafmersmann
2020-12-14 14:24 ` ericonr
2020-12-14 14:28 ` olafmersmann
2020-12-14 14:37 ` ericonr
2020-12-14 21:31 ` [PR PATCH] [Updated] " olafmersmann
2020-12-16 21:18 ` [PR REVIEW] " ahesford
2020-12-16 21:18 ` ahesford
2020-12-16 21:18 ` ahesford
2020-12-17  7:49 ` [PR PATCH] [Updated] " olafmersmann
2020-12-17  7:51 ` [PR REVIEW] " olafmersmann
2020-12-17  7:52 ` olafmersmann
2020-12-17  7:53 ` olafmersmann
2021-01-06 16:34 ` ahesford [this message]
2021-01-06 17:26 ` [PR PATCH] [Closed]: " ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210106163409.k_brdjb1t4NlMWteUdRQ3HsPhlGVX6jIYcPUyHQXHKs@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).