From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] consensus on $distfiles
Date: Thu, 07 Jan 2021 13:10:24 +0100 [thread overview]
Message-ID: <20210107121024.7uEVv0ZwHueu_RN6DaoiAf-ltyf6iGD4K1DkacXk0Ig@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27735@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/issues/27735#issuecomment-756078086
Comment:
+1 for encouraging use of variables whenever possible in distfiles.
The primary justification for keeping the homepage and change log free from variables is that these things should be easy to copy and paste (or, in some terminal emulators, directly clickable).
No such justification applies to distfiles, which are already encouraged to use `$version`. It would be inconsistent and, in my view, senseless to demand that some variables be used while others be avoided.
When I make changes, I use the shortest possible form for distfiles. However, I tend not to demand a specific style when reviewing others' work. (Although I may suggest such a change when it would be one of many other demands.)
EDIT: sorry for the accidental close.
next prev parent reply other threads:[~2021-01-07 12:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 9:49 [ISSUE] [RFC] Consencus " fosslinux
2021-01-07 9:52 ` Piraty
2021-01-07 12:08 ` [RFC] consensus " ahesford
2021-01-07 12:08 ` [ISSUE] [CLOSED] " ahesford
2021-01-07 12:10 ` ahesford [this message]
2021-01-07 12:25 ` Duncaen
2021-01-07 12:26 ` Duncaen
2021-01-07 13:13 ` Anachron
2021-01-07 13:38 ` sgn
2021-01-07 13:46 ` Duncaen
2021-01-07 13:58 ` ericonr
2021-01-07 15:19 ` Vaelatern
2021-01-07 15:22 ` Vaelatern
2021-01-07 19:57 ` Piraty
2021-01-07 21:54 ` Chocimier
2021-01-08 5:06 ` ericonr
2021-01-08 5:06 ` ericonr
2021-01-08 5:23 ` Vaelatern
2021-01-08 5:30 ` ericonr
2022-03-26 18:26 ` subnut
2022-03-26 21:34 ` ahesford
2022-06-25 2:15 ` github-actions
2022-07-10 2:14 ` [ISSUE] [CLOSED] " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107121024.7uEVv0ZwHueu_RN6DaoiAf-ltyf6iGD4K1DkacXk0Ig@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).