From: q66 <q66@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] build grub-x86_64-efi for i686
Date: Sat, 09 Jan 2021 04:50:29 +0100 [thread overview]
Message-ID: <20210109035029.fKeHEAfm_2fnTAKjYk0Tt73UxoGH47-XffYJhRnne_4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26895@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
New review comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/26895#discussion_r554285633
Comment:
i don't like this weird block/substitution, considering the extra platform files are basically arch-independent, there should be no harm in simply configuring them all with empty `CFLAGS`
remove all your changes regarding switch to `BASE_CFLAGS`, and then simply pass `CFLAGS=""` as an argument to configure for each supplementary build
next prev parent reply other threads:[~2021-01-09 3:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 0:37 [PR PATCH] " sgn
2020-12-03 0:48 ` ericonr
2020-12-03 0:48 ` [PR REVIEW] " ericonr
2020-12-03 0:55 ` [PR PATCH] [Updated] " sgn
2020-12-03 14:01 ` sgn
2020-12-03 15:00 ` [PR REVIEW] " sgn
2020-12-05 3:48 ` [PR PATCH] [Updated] " sgn
2020-12-05 11:30 ` sgn
2020-12-05 11:30 ` sgn
2020-12-06 4:31 ` sgn
2020-12-07 0:03 ` [PR PATCH] [Closed]: " sgn
2020-12-26 7:26 ` fosslinux
2021-01-04 2:09 ` ericonr
2021-01-04 9:33 ` fosslinux
2021-01-09 3:19 ` [PR PATCH] [Updated] " sgn
2021-01-09 3:47 ` [PR REVIEW] " q66
2021-01-09 3:50 ` q66 [this message]
2021-01-09 3:51 ` q66
2021-01-09 6:02 ` [PR PATCH] [Updated] " sgn
2021-01-09 6:21 ` sgn
2021-01-09 13:56 ` [PR REVIEW] " q66
2021-01-09 15:55 ` sgn
2021-01-18 11:33 ` [PR PATCH] [Updated] " sgn
2021-01-18 12:36 ` [PR REVIEW] " q66
2021-01-18 12:39 ` q66
2021-01-18 13:25 ` [PR PATCH] [Updated] " sgn
2021-01-20 0:41 ` [PR PATCH] [Merged]: " q66
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210109035029.fKeHEAfm_2fnTAKjYk0Tt73UxoGH47-XffYJhRnne_4@z \
--to=q66@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).