From: olafmersmann <olafmersmann@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] shutils/chroot.sh: create symlink for /etc/localtime
Date: Sun, 10 Jan 2021 16:15:20 +0100 [thread overview]
Message-ID: <20210110151520.qpzozW6xbfZFa6NKeihiDdV0q1cslTEh3kUWzPsOU2A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27803@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
New review comment by olafmersmann on void-packages repository
https://github.com/void-linux/void-packages/pull/27803#discussion_r554581328
Comment:
I agree, but kept the original logic for a first draft. Not sure if there are any side effects I haven't thought of if localtime is always UTC. If there are no objections, I'll simplify the patch to always set localtime to UTC inside the chroot.
next prev parent reply other threads:[~2021-01-10 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 8:37 [PR PATCH] " olafmersmann
2021-01-10 11:29 ` [PR REVIEW] " sgn
2021-01-10 15:15 ` olafmersmann [this message]
2021-01-10 15:35 ` [PR PATCH] [Updated] " olafmersmann
2021-01-14 13:50 ` ahesford
2021-01-14 14:06 ` [PR REVIEW] " ahesford
2021-01-14 22:51 ` olafmersmann
2021-01-14 22:59 ` olafmersmann
2021-01-14 23:00 ` [PR PATCH] [Updated] " olafmersmann
2021-01-14 23:03 ` olafmersmann
2021-01-20 1:13 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210110151520.qpzozW6xbfZFa6NKeihiDdV0q1cslTEh3kUWzPsOU2A@z \
--to=olafmersmann@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).