From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: stressapptest-1.0.9.
Date: Tue, 12 Jan 2021 14:33:59 +0100 [thread overview]
Message-ID: <20210112133359.Hl_Qn-g6P4kjYWnweLM3cX5-v_9rcJc5h0lo7KPQEgk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24528@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/24528#discussion_r555772264
Comment:
From the generic glibc version:
```
case _SC_LEVEL1_ICACHE_SIZE:
case _SC_LEVEL1_ICACHE_ASSOC:
case _SC_LEVEL1_ICACHE_LINESIZE:
case _SC_LEVEL1_DCACHE_SIZE:
case _SC_LEVEL1_DCACHE_ASSOC:
case _SC_LEVEL1_DCACHE_LINESIZE:
case _SC_LEVEL2_CACHE_SIZE:
case _SC_LEVEL2_CACHE_ASSOC:
case _SC_LEVEL2_CACHE_LINESIZE:
case _SC_LEVEL3_CACHE_SIZE:
case _SC_LEVEL3_CACHE_ASSOC:
case _SC_LEVEL3_CACHE_LINESIZE:
case _SC_LEVEL4_CACHE_SIZE:
case _SC_LEVEL4_CACHE_ASSOC:
case _SC_LEVEL4_CACHE_LINESIZE:
/* In general we cannot determine these values. Therefore we
return zero which indicates that no information is
available. */
return 0;
```
Then they have these files which for the most part implement the linesize detection for each arch:
```
sysdeps/unix/sysv/linux/aarch64/sysconf.c
sysdeps/unix/sysv/linux/alpha/sysconf.c
sysdeps/unix/sysv/linux/powerpc/sysconf.c
sysdeps/unix/sysv/linux/riscv/sysconf.c
sysdeps/unix/sysv/linux/s390/sysconf.c
sysdeps/unix/sysv/linux/x86/sysconf.c
```
It seems `x86_64` isn't even covered, unless they use `x86` in it?
Anyway, should be ok to add a patch with `#ifdef` guards around the block for one of those values, and return 0 otherwise.
next prev parent reply other threads:[~2021-01-12 13:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 23:38 [PR PATCH] " fosslinux
2020-08-28 23:39 ` [PR PATCH] [Updated] " fosslinux
2021-01-12 4:21 ` tarkov2213
2021-01-12 4:44 ` [PR REVIEW] " ericonr
2021-01-12 4:45 ` ericonr
2021-01-12 10:31 ` fosslinux
2021-01-12 10:39 ` fosslinux
2021-01-12 10:43 ` fosslinux
2021-01-12 13:33 ` ericonr [this message]
2021-01-12 21:37 ` fosslinux
2021-01-12 22:59 ` [PR PATCH] [Updated] " fosslinux
2021-01-12 23:00 ` fosslinux
2021-01-13 2:12 ` ericonr
2021-01-13 2:15 ` tarkov2213
2021-01-13 6:44 ` fosslinux
2021-01-13 6:47 ` fosslinux
2022-04-18 2:12 ` github-actions
2022-05-02 2:15 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112133359.Hl_Qn-g6P4kjYWnweLM3cX5-v_9rcJc5h0lo7KPQEgk@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).