Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] frei0r-plugins: update to 1.7.0.
@ 2021-01-11 18:15 tibequadorian
  2021-01-12  3:23 ` [PR REVIEW] " ericonr
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: tibequadorian @ 2021-01-11 18:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

There is a new pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages frei0r-plugins
https://github.com/void-linux/void-packages/pull/27830

frei0r-plugins: update to 1.7.0.
Also added build options for cairo and gavl.

A patch file from https://github.com/void-linux/void-packages/pull/27830.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-frei0r-plugins-27830.patch --]
[-- Type: text/x-diff, Size: 1289 bytes --]

From 235bb64b88755c7c605807c4865e514ee3831b7d Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 11 Jan 2021 19:06:12 +0100
Subject: [PATCH] frei0r-plugins: update to 1.7.0.

Also added build options for cairo and gavl.
---
 srcpkgs/frei0r-plugins/template | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/frei0r-plugins/template b/srcpkgs/frei0r-plugins/template
index 54adf54a355..d22091cb141 100644
--- a/srcpkgs/frei0r-plugins/template
+++ b/srcpkgs/frei0r-plugins/template
@@ -1,12 +1,16 @@
 # Template file for 'frei0r-plugins'
 pkgname=frei0r-plugins
-version=1.6.1
+version=1.7.0
 revision=1
 build_style=cmake
 hostmakedepends="autoconf"
+makedepends="$(vopt_if gavl gavl-devel) $(vopt_if cairo cairo-devel)"
 short_desc="Minimalistic API for a collection of free video effects plugins"
 maintainer="Diogo Leal <diogo@diogoleal.com>"
-license="GPL-2"
+license="GPL-2.0-or-later"
 homepage="http://frei0r.dyne.org/"
 distfiles="https://files.dyne.org/frei0r/releases/frei0r-plugins-${version}.tar.gz"
-checksum=e0c24630961195d9bd65aa8d43732469e8248e8918faa942cfb881769d11515e
+checksum=1b1ff8f0f9bc23eed724e94e9a7c1d8f0244bfe33424bb4fe68e6460c088523a
+
+build_options="cairo gavl"
+build_options_default="cairo"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] frei0r-plugins: update to 1.7.0.
  2021-01-11 18:15 [PR PATCH] frei0r-plugins: update to 1.7.0 tibequadorian
@ 2021-01-12  3:23 ` ericonr
  2021-01-12 10:25 ` tibequadorian
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-01-12  3:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27830#discussion_r555485984

Comment:
Why not enable both?

Also, their build system seems to search for OpenCV as well. Do we want to enable that?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] frei0r-plugins: update to 1.7.0.
  2021-01-11 18:15 [PR PATCH] frei0r-plugins: update to 1.7.0 tibequadorian
  2021-01-12  3:23 ` [PR REVIEW] " ericonr
@ 2021-01-12 10:25 ` tibequadorian
  2021-01-12 13:10 ` ericonr
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: tibequadorian @ 2021-01-12 10:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

New review comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27830#discussion_r555664851

Comment:
I thought to keep dependencies by default rather minimal and cairo is probably installed anyway, gavl is not.
I tried OpenCV (3 and 4) as well but it failed with different error messages. Maybe someone else knows how to do this...

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] frei0r-plugins: update to 1.7.0.
  2021-01-11 18:15 [PR PATCH] frei0r-plugins: update to 1.7.0 tibequadorian
  2021-01-12  3:23 ` [PR REVIEW] " ericonr
  2021-01-12 10:25 ` tibequadorian
@ 2021-01-12 13:10 ` ericonr
  2021-01-12 13:11 ` ericonr
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-01-12 13:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27830#discussion_r555758229

Comment:
Fair enough, this should be adding more functionality as is already.

Can you leave a comment about OpenCV also being a possible dependency? `# XXX: ...`

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: frei0r-plugins: update to 1.7.0.
  2021-01-11 18:15 [PR PATCH] frei0r-plugins: update to 1.7.0 tibequadorian
                   ` (2 preceding siblings ...)
  2021-01-12 13:10 ` ericonr
@ 2021-01-12 13:11 ` ericonr
  2021-01-12 17:14 ` tibequadorian
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-01-12 13:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27830#issuecomment-758645686

Comment:
Ah, which software have you tried it with?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: frei0r-plugins: update to 1.7.0.
  2021-01-11 18:15 [PR PATCH] frei0r-plugins: update to 1.7.0 tibequadorian
                   ` (3 preceding siblings ...)
  2021-01-12 13:11 ` ericonr
@ 2021-01-12 17:14 ` tibequadorian
  2021-01-12 17:39 ` [PR REVIEW] " tibequadorian
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: tibequadorian @ 2021-01-12 17:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27830#issuecomment-758807925

Comment:
> Ah, which software have you tried it with?

kdenlive, it worked fine

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] frei0r-plugins: update to 1.7.0.
  2021-01-11 18:15 [PR PATCH] frei0r-plugins: update to 1.7.0 tibequadorian
                   ` (4 preceding siblings ...)
  2021-01-12 17:14 ` tibequadorian
@ 2021-01-12 17:39 ` tibequadorian
  2021-01-12 17:42 ` tibequadorian
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: tibequadorian @ 2021-01-12 17:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New review comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27830#discussion_r555955548

Comment:
sry what do you mean by that `# XXX: ...` what comes instead of `XXX` ? :smile: 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] frei0r-plugins: update to 1.7.0.
  2021-01-11 18:15 [PR PATCH] frei0r-plugins: update to 1.7.0 tibequadorian
                   ` (5 preceding siblings ...)
  2021-01-12 17:39 ` [PR REVIEW] " tibequadorian
@ 2021-01-12 17:42 ` tibequadorian
  2021-01-12 17:50 ` [PR PATCH] [Updated] " tibequadorian
  2021-01-12 18:13 ` [PR PATCH] [Merged]: " ericonr
  8 siblings, 0 replies; 10+ messages in thread
From: tibequadorian @ 2021-01-12 17:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27830#discussion_r555957327

Comment:
ohh I didn't know it was a convention! nvm

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] frei0r-plugins: update to 1.7.0.
  2021-01-11 18:15 [PR PATCH] frei0r-plugins: update to 1.7.0 tibequadorian
                   ` (6 preceding siblings ...)
  2021-01-12 17:42 ` tibequadorian
@ 2021-01-12 17:50 ` tibequadorian
  2021-01-12 18:13 ` [PR PATCH] [Merged]: " ericonr
  8 siblings, 0 replies; 10+ messages in thread
From: tibequadorian @ 2021-01-12 17:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages frei0r-plugins
https://github.com/void-linux/void-packages/pull/27830

frei0r-plugins: update to 1.7.0.
Also added build options for cairo and gavl.

A patch file from https://github.com/void-linux/void-packages/pull/27830.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-frei0r-plugins-27830.patch --]
[-- Type: text/x-diff, Size: 1342 bytes --]

From 2c5d9a40484378ee0c841b8d7c20ed3638f6f4c8 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 11 Jan 2021 19:06:12 +0100
Subject: [PATCH] frei0r-plugins: update to 1.7.0.

Also added build options for cairo and gavl.
---
 srcpkgs/frei0r-plugins/template | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/frei0r-plugins/template b/srcpkgs/frei0r-plugins/template
index 54adf54a355..e980aa63617 100644
--- a/srcpkgs/frei0r-plugins/template
+++ b/srcpkgs/frei0r-plugins/template
@@ -1,12 +1,17 @@
 # Template file for 'frei0r-plugins'
 pkgname=frei0r-plugins
-version=1.6.1
+version=1.7.0
 revision=1
 build_style=cmake
 hostmakedepends="autoconf"
+# XXX: opencv should also be a possible dependency
+makedepends="$(vopt_if gavl gavl-devel) $(vopt_if cairo cairo-devel)"
 short_desc="Minimalistic API for a collection of free video effects plugins"
 maintainer="Diogo Leal <diogo@diogoleal.com>"
-license="GPL-2"
+license="GPL-2.0-or-later"
 homepage="http://frei0r.dyne.org/"
 distfiles="https://files.dyne.org/frei0r/releases/frei0r-plugins-${version}.tar.gz"
-checksum=e0c24630961195d9bd65aa8d43732469e8248e8918faa942cfb881769d11515e
+checksum=1b1ff8f0f9bc23eed724e94e9a7c1d8f0244bfe33424bb4fe68e6460c088523a
+
+build_options="cairo gavl"
+build_options_default="cairo"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Merged]: frei0r-plugins: update to 1.7.0.
  2021-01-11 18:15 [PR PATCH] frei0r-plugins: update to 1.7.0 tibequadorian
                   ` (7 preceding siblings ...)
  2021-01-12 17:50 ` [PR PATCH] [Updated] " tibequadorian
@ 2021-01-12 18:13 ` ericonr
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-01-12 18:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

There's a merged pull request on the void-packages repository

frei0r-plugins: update to 1.7.0.
https://github.com/void-linux/void-packages/pull/27830

Description:
Also added build options for cairo and gavl.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-01-12 18:13 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 18:15 [PR PATCH] frei0r-plugins: update to 1.7.0 tibequadorian
2021-01-12  3:23 ` [PR REVIEW] " ericonr
2021-01-12 10:25 ` tibequadorian
2021-01-12 13:10 ` ericonr
2021-01-12 13:11 ` ericonr
2021-01-12 17:14 ` tibequadorian
2021-01-12 17:39 ` [PR REVIEW] " tibequadorian
2021-01-12 17:42 ` tibequadorian
2021-01-12 17:50 ` [PR PATCH] [Updated] " tibequadorian
2021-01-12 18:13 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).