Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [NEEDS TESTERS] rpi-kernel: build a subpackage for each flavor, add rpi4
Date: Wed, 13 Jan 2021 03:42:16 +0100	[thread overview]
Message-ID: <20210113024216.k4uAmxV-_rd4u04tvMagrcEBQZMLAAUglv6MdDFTlaI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26000@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/26000#discussion_r556227141

Comment:
This block causes problems because some dtb files are missing in `rpi3-kernel` and `rpi4-kernel` (the same problem affects the current `rpi3-kernel` package). For example, on my 3b+ which tries to use NFS root with kernel IP configuration, the Ethernet adapter gets a new, random MAC address with every boot. The `smsc95xx.macaddr` kernel command-line argument makes no difference. The problem is resolved by copying `/boot/broadcom/bcm2710-rpi-3-b-plus.dtb` and `/boot/broadcom/bcm2837-rpi-3-b-plus.dtb` to `/boot`.

I think the right thing here is to copy all of the relevant family and SoC dtb files (see [this table](https://openwrt.org/toh/raspberry_pi_foundation/raspberry_pi#hardware)):

```bash
case "$rpi_flavor in
	rpi3)
		mv ${DESTDIR}/boot/broadcom/bcm{2710,2837}-*.dtb ${DESTDIR}/boot
		;;
	rpi4)
		mv ${DESTDIR}/boot/broadcom/bcm2711-*.dtb ${DESTDIR}/boot
		;;
esac
rm -rf ${DESTDIR}/broadcom
```
This should capture all of the proper DTBs for `rpi3`-class hardware. For `rpi4`, there is currently only one DTB, but it looks like there are more `bcm2711-*` DTBs for the RPi 400 and CM4 [coming in 5.10.x](https://github.com/raspberrypi/linux/tree/rpi-5.10.y/arch/arm/boot/dts), so doing a glob probably saves us some trouble later.

  parent reply	other threads:[~2021-01-13  2:42 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-31 16:17 [PR PATCH] " Piraty
2020-10-31 16:27 ` [PR PATCH] [Updated] " Piraty
2020-10-31 16:36 ` Piraty
2020-11-06 23:34 ` [NEEDS TESTERS] " liketechnik
2020-11-16  3:32 ` [PR REVIEW] " agausmann
2020-11-16  3:34 ` agausmann
2020-11-16  3:36 ` agausmann
2020-11-16  3:57 ` agausmann
2020-11-16  3:58 ` agausmann
2020-11-16  3:59 ` agausmann
2020-11-17  9:10 ` [PR REVIEW] " Piraty
2020-11-22 18:23 ` Piraty
2020-11-22 19:48 ` Piraty
2020-11-22 20:58 ` agausmann
2020-12-29  7:49 ` manneorama
2020-12-29  7:59 ` manneorama
2020-12-29  8:10 ` manneorama
2020-12-29  9:03 ` manneorama
2020-12-29  9:48 ` manneorama
2020-12-29 10:53 ` manneorama
2020-12-31  1:42 ` [PR PATCH] [Updated] " Piraty
2021-01-03 23:08 ` manneorama
2021-01-05  9:36 ` Anachron
2021-01-05 19:48 ` LeamHall
2021-01-06 19:21 ` manneorama
2021-01-07  1:18 ` CMB
2021-01-07  2:04 ` LeamHall
2021-01-07  2:20 ` LeamHall
2021-01-11  0:24 ` [PR REVIEW] " ahesford
2021-01-11  2:02 ` ericonr
2021-01-11  2:02 ` ericonr
2021-01-11  2:57 ` jsumners
2021-01-11  3:17 ` ericonr
2021-01-11  3:51 ` jsumners
2021-01-11  4:14 ` ericonr
2021-01-11  5:04 ` ahesford
2021-01-11 11:19 ` Piraty
2021-01-11 11:21 ` Piraty
2021-01-11 11:25 ` Piraty
2021-01-11 13:17 ` ahesford
2021-01-11 13:20 ` ericonr
2021-01-12 20:19 ` [PR PATCH] [Updated] " Piraty
2021-01-13  2:42 ` ahesford [this message]
2021-01-16 22:38 ` [PR REVIEW] " CameronNemo
2021-01-16 23:36 ` [PR PATCH] [Updated] " Piraty
2021-01-16 23:37 ` [PR REVIEW] " Piraty
2021-01-16 23:49 ` Piraty
2021-01-16 23:49 ` Piraty
2021-01-17  0:22 ` [WIP] " ahesford
2021-01-18  9:44 ` [PR REVIEW] " Piraty
2021-01-18 21:48 ` ericonr
2021-01-23 17:30 ` Bridouz
2021-01-23 20:22 ` jsumners
2021-01-28  6:28 ` Bridouz
2021-02-05 10:20 ` paper42
2021-02-10 19:03 ` jsav0
2021-02-11 19:45 ` [PR PATCH] [Updated] " Piraty
2021-02-11 20:01 ` [PR PATCH] [Updated] [WIP] rpi-kernel: split into flavor packages, " Piraty
2021-02-11 20:03 ` Piraty
2021-02-12 18:15 ` Piraty
2021-04-27 19:43 ` [WIP] rpi-kernel: build flavor subpackages, " Piraty
2021-04-27 19:43 ` [PR PATCH] [Closed]: " Piraty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113024216.k4uAmxV-_rd4u04tvMagrcEBQZMLAAUglv6MdDFTlaI@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).