From: ScrelliCopter <ScrelliCopter@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: genie-1141
Date: Sun, 17 Jan 2021 06:32:34 +0100 [thread overview]
Message-ID: <20210117053234.wcBlFbzwsYiBmO3w9IuNjlmn-41WXb7kt_9-sHXMee8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27915@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
New review comment by ScrelliCopter on void-packages repository
https://github.com/void-linux/void-packages/pull/27915#discussion_r559081023
Comment:
@Piraty I changed the convention to match what you were referring to, or did you also mean replacing the usage of Git with just getting the commit directly from GitHub?
The reason I'm using Git is because [these](https://github.com/bkaradzic/GENie/blob/44918162588e56512ddac6264b08ca6ba4e67468/scripts/release.lua#L18) [lines](https://github.com/bkaradzic/GENie/blob/44918162588e56512ddac6264b08ca6ba4e67468/scripts/release.lua#L21) use `git` to glean information about the version, which fails without an actual Git repository.
I could try patching these lines myself because they're just getting strings that I already know about in the template, and then the hostmakedepends=git could be omitted entirely in favour of just fetching the commit directly. Which would be preferred?
next prev parent reply other threads:[~2021-01-17 5:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 8:56 [PR PATCH] " ScrelliCopter
2021-01-14 13:13 ` [PR PATCH] [Updated] " ScrelliCopter
2021-01-14 13:15 ` ScrelliCopter
2021-01-17 0:23 ` [PR REVIEW] " Piraty
2021-01-17 5:18 ` [PR PATCH] [Updated] " ScrelliCopter
2021-01-17 5:32 ` ScrelliCopter [this message]
2021-01-18 12:03 ` [PR REVIEW] " Piraty
2021-01-18 12:05 ` Piraty
2021-01-18 15:50 ` [PR PATCH] [Updated] " ScrelliCopter
2021-01-18 15:57 ` [PR REVIEW] " ScrelliCopter
2021-01-18 15:57 ` ScrelliCopter
2021-01-18 17:48 ` Chocimier
2021-01-19 6:55 ` ScrelliCopter
2021-01-27 14:14 ` [PR REVIEW] " Piraty
2021-01-28 5:57 ` [PR PATCH] [Updated] " ScrelliCopter
2021-01-28 5:59 ` [PR REVIEW] " ScrelliCopter
2021-01-28 14:13 ` Piraty
2021-01-28 14:13 ` Piraty
2021-01-28 20:59 ` [PR PATCH] [Updated] " ScrelliCopter
2021-01-28 21:01 ` [PR REVIEW] " ScrelliCopter
2021-01-28 21:02 ` ScrelliCopter
2021-01-28 21:10 ` ScrelliCopter
2021-01-28 21:11 ` ScrelliCopter
2021-04-26 3:45 ` [PR PATCH] [Closed]: " ScrelliCopter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210117053234.wcBlFbzwsYiBmO3w9IuNjlmn-41WXb7kt_9-sHXMee8@z \
--to=screllicopter@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).