From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: opendoas: set permissions during do_install.
Date: Sun, 17 Jan 2021 19:58:39 +0100 [thread overview]
Message-ID: <20210117185839.usPmSajHhdWglgBwnp7ggD3td1JLmCYD77xjdBxaNU8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27958@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
There's a merged pull request on the void-packages repository
opendoas: set permissions during do_install.
https://github.com/void-linux/void-packages/pull/27958
Description:
- setting permissions in a INSTALL script makes the program unusable
between it being unpacked and the INSTALL script actually being run; for
users with other long running post-install steps, e.g. DKMS modules,
this can be a long time where an administrative tool can't be used.
- furthermore, any interruption of the post-install steps or a power
failure will have a much higher probability of leaving the user with a
non suid executable than if it had been set at install time.
- making the binary permissions 4111 isn't necessary; the binary can be
retrieved in multiple manners, so this doesn't offer any protection (and
the binary would be "unprotected" anyway while INSTALL hasn't run yet).
opendoas's makefile can chmod the executable, so we just stop removing the
chmod line from its makefile.
@Duncaen
prev parent reply other threads:[~2021-01-17 18:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 23:08 [PR PATCH] " ericonr
2021-01-15 23:21 ` [PR REVIEW] " Duncaen
2021-01-15 23:24 ` [PR PATCH] [Updated] " ericonr
2021-01-15 23:25 ` ericonr
2021-01-15 23:25 ` [PR REVIEW] " ericonr
2021-01-17 18:58 ` ericonr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210117185839.usPmSajHhdWglgBwnp7ggD3td1JLmCYD77xjdBxaNU8@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).