From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] plocate-1.1.3
Date: Mon, 18 Jan 2021 00:22:59 +0100 [thread overview]
Message-ID: <20210117232259.qiyKeujNpeQn5GVmizspEknv8bw1QiEwmZ_ETGlNaa0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27991@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/27991#discussion_r559254925
Comment:
hm yea not sure if its worth it, after looking at the actual implementation of this in glibc, its probably better to just patch the programs using it and get it upstreamed, there is no real value in `error.h`.
I was expecting there to be some localization stuff or similar.
next prev parent reply other threads:[~2021-01-17 23:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 20:37 [PR PATCH] plocate-1.1.3 Duncaen
2021-01-17 20:44 ` plocate-1.1.3 leahneukirchen
2021-01-17 20:57 ` [PR PATCH] [Updated] plocate-1.1.3 Duncaen
2021-01-17 22:27 ` [PR REVIEW] plocate-1.1.3 ericonr
2021-01-17 23:08 ` Duncaen
2021-01-17 23:08 ` Duncaen
2021-01-17 23:12 ` ericonr
2021-01-17 23:22 ` Duncaen [this message]
2021-01-19 22:59 ` plocate-1.1.3 ericonr
2021-01-19 23:52 ` plocate-1.1.3 Duncaen
2021-02-02 11:13 ` plocate-1.1.3 leahneukirchen
2021-04-06 12:37 ` [PR PATCH] [Updated] plocate-1.1.3 Duncaen
2021-06-13 20:08 ` [PR PATCH] [Closed]: plocate-1.1.3 Duncaen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210117232259.qiyKeujNpeQn5GVmizspEknv8bw1QiEwmZ_ETGlNaa0@z \
--to=duncaen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).