* [PR PATCH] .github: add pull request template
@ 2019-10-25 23:14 voidlinux-github
2019-10-26 5:06 ` voidlinux-github
` (22 more replies)
0 siblings, 23 replies; 24+ messages in thread
From: voidlinux-github @ 2019-10-25 23:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
There is a new pull request by Piraty against master on the void-packages repository
https://github.com/Piraty/void-packages github-pr-template
https://github.com/void-linux/void-packages/pull/15798
.github: add pull request template
A patch file from https://github.com/void-linux/void-packages/pull/15798.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-pr-template-15798.patch --]
[-- Type: text/x-diff, Size: 1522 bytes --]
From ad34abe6bf52024181a0f8488871870ff1550071 Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Sat, 26 Oct 2019 00:56:58 +0200
Subject: [PATCH] .github: add pull request template
---
.github/pull_request_template.md | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 .github/pull_request_template.md
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 00000000000..22842f42000
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,19 @@
+<!-- Please mark items with [x] where applicable -->
+
+<!-- If Travis cannot be used to validate the build result (for example if the
+build exceeds the timecap of 45min), make sure to put "[ci skip]" the HEAD
+commit, so travis builds are skipped completely (saves build resources).
+You can remove this section in case Travis is used -->
+#### Does it build successfully? (Long builds, > 45min)
+- [ ] I built this PR locally for my native architecture, glibc
+- [ ] I built this PR locally for my native architecture, musl libc
+- [ ] I built this PR locally for at these cross architectures: <!-- check at least two -->
+ - [ ] aarch64
+ - [ ] aarch64-musl
+ - [ ] armv7l
+ - [ ] armv7l-musl
+
+#### Do the results of the proposed changes work?
+- [ ] I use the packages affected by the proposed changes on a regular basis and confirm they work for me
+- [ ] I generally don't use the affected packages but briefly tested this PR
+- [ ] I did not test the result
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
@ 2019-10-26 5:06 ` voidlinux-github
2019-10-27 15:52 ` [PR PATCH] [Updated] " voidlinux-github
` (21 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: voidlinux-github @ 2019-10-26 5:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#issuecomment-546569841
Comment:
Suggestion: by default comment out the part that only should be used when travis isn't used? And then let people uncomment it when they need it? I feel like it commented-out should be the default as for the majority of PRs travis will be used.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
2019-10-26 5:06 ` voidlinux-github
@ 2019-10-27 15:52 ` voidlinux-github
2019-10-27 15:52 ` voidlinux-github
` (20 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: voidlinux-github @ 2019-10-27 15:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
There is an updated pull request by Piraty against master on the void-packages repository
https://github.com/Piraty/void-packages github-pr-template
https://github.com/void-linux/void-packages/pull/15798
.github: add pull request template
A patch file from https://github.com/void-linux/void-packages/pull/15798.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-pr-template-15798.patch --]
[-- Type: text/x-diff, Size: 1537 bytes --]
From 904b4d2a9f98ba2804ce21d2bf00c1c3ad0de1ee Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Sat, 26 Oct 2019 00:56:58 +0200
Subject: [PATCH] .github: add pull request template
---
.github/pull_request_template.md | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 .github/pull_request_template.md
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 00000000000..0aa6b3d9b56
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,21 @@
+<!-- Please mark items with [x] where applicable -->
+
+<!-- If Travis cannot be used to validate the build result (for example if the
+build exceeds the timecap of 45min), make sure to put "[ci skip]" in the HEAD
+commit, which skips travis builds completely (saves CI resources). Uncomment the
+following section in this case. -->
+<!--
+#### Does it build successfully? (Long builds, > 45min)
+- [ ] I built this PR locally for my native architecture, glibc
+- [ ] I built this PR locally for my native architecture, musl libc
+- [ ] I built this PR locally for at these cross architectures: <!-- check at least two -->
+ - [ ] aarch64
+ - [ ] aarch64-musl
+ - [ ] armv7l
+ - [ ] armv7l-musl
+-->
+
+#### Have the results of the proposed changes been tested?
+- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
+- [ ] I generally don't use the affected packages but briefly tested this PR
+- [ ] I did not test this PR
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
2019-10-26 5:06 ` voidlinux-github
2019-10-27 15:52 ` [PR PATCH] [Updated] " voidlinux-github
@ 2019-10-27 15:52 ` voidlinux-github
2020-11-15 13:41 ` Piraty
` (19 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: voidlinux-github @ 2019-10-27 15:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
There is an updated pull request by Piraty against master on the void-packages repository
https://github.com/Piraty/void-packages github-pr-template
https://github.com/void-linux/void-packages/pull/15798
.github: add pull request template
A patch file from https://github.com/void-linux/void-packages/pull/15798.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-pr-template-15798.patch --]
[-- Type: text/x-diff, Size: 1537 bytes --]
From 904b4d2a9f98ba2804ce21d2bf00c1c3ad0de1ee Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Sat, 26 Oct 2019 00:56:58 +0200
Subject: [PATCH] .github: add pull request template
---
.github/pull_request_template.md | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 .github/pull_request_template.md
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 00000000000..0aa6b3d9b56
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,21 @@
+<!-- Please mark items with [x] where applicable -->
+
+<!-- If Travis cannot be used to validate the build result (for example if the
+build exceeds the timecap of 45min), make sure to put "[ci skip]" in the HEAD
+commit, which skips travis builds completely (saves CI resources). Uncomment the
+following section in this case. -->
+<!--
+#### Does it build successfully? (Long builds, > 45min)
+- [ ] I built this PR locally for my native architecture, glibc
+- [ ] I built this PR locally for my native architecture, musl libc
+- [ ] I built this PR locally for at these cross architectures: <!-- check at least two -->
+ - [ ] aarch64
+ - [ ] aarch64-musl
+ - [ ] armv7l
+ - [ ] armv7l-musl
+-->
+
+#### Have the results of the proposed changes been tested?
+- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
+- [ ] I generally don't use the affected packages but briefly tested this PR
+- [ ] I did not test this PR
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (2 preceding siblings ...)
2019-10-27 15:52 ` voidlinux-github
@ 2020-11-15 13:41 ` Piraty
2020-12-18 14:14 ` [PR REVIEW] " ahesford
` (18 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: Piraty @ 2020-11-15 13:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
There is an updated pull request by Piraty against master on the void-packages repository
https://github.com/Piraty/void-packages github-pr-template
https://github.com/void-linux/void-packages/pull/15798
.github: add pull request template
A patch file from https://github.com/void-linux/void-packages/pull/15798.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-pr-template-15798.patch --]
[-- Type: text/x-diff, Size: 1507 bytes --]
From 644ccbee18bd7ee82019c6014f7e97a735c6f68e Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Sat, 26 Oct 2019 00:56:58 +0200
Subject: [PATCH] .github: add pull request template
---
.github/pull_request_template.md | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 .github/pull_request_template.md
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 00000000000..7b527b7745c
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,19 @@
+<!-- Mark items with [x] where applicable -->
+#### Have the results of the proposed changes been tested?
+- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
+- [ ] I generally don't use the affected packages but briefly tested this PR
+- [ ] I did not test this PR
+
+<!-- If Travis cannot be used to validate the build result (for example if the
+build exceeds the timecap of 45min), make sure to put "[ci skip]" in the HEAD
+commit, which skips travis builds completely (saves CI resources). Uncomment the
+following section in this case. -->
+<!--
+#### Does it build successfully? (Only if builds take too long for CI)
+- [ ] I built this PR locally for my native architecture, glibc
+- [ ] I built this PR locally for my native architecture, musl libc
+- [ ] I built this PR locally for these cross architectures (if supported):
+ - [ ] aarch64-musl
+ - [ ] armv7l
+ - [ ] armv6l-musl
+-->
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (3 preceding siblings ...)
2020-11-15 13:41 ` Piraty
@ 2020-12-18 14:14 ` ahesford
2020-12-18 14:14 ` ahesford
` (17 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-12-18 14:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#discussion_r545850040
Comment:
Remove this option. Being forced to leave the test options blank without testing might cause some people to do a bit more testing before submitting PRs.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (4 preceding siblings ...)
2020-12-18 14:14 ` [PR REVIEW] " ahesford
@ 2020-12-18 14:14 ` ahesford
2020-12-18 14:14 ` ahesford
` (16 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-12-18 14:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#discussion_r545855963
Comment:
> Does it build and run successfully? (Please choose at least one native build and, if supported, at least one cross build. More are better.)
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (5 preceding siblings ...)
2020-12-18 14:14 ` ahesford
@ 2020-12-18 14:14 ` ahesford
2020-12-18 14:15 ` ericonr
` (15 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-12-18 14:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#discussion_r545854699
Comment:
> If GitHub CI cannot be used to validate the build result (for example, if the build is likely to take several hours), make sure to include "[ci skip]' in either the PR title or this description. When skipping CI, uncomment and complete the following section. Note: for builds that are likely to complete in less than XXX hours, it is not acceptable to skip CI.
(I don't know the time limit, but XXX needs to be filled in.)
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (6 preceding siblings ...)
2020-12-18 14:14 ` ahesford
@ 2020-12-18 14:15 ` ericonr
2020-12-18 14:16 ` ericonr
` (14 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-12-18 14:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#discussion_r545857188
Comment:
The hard limit is 6 hours.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (7 preceding siblings ...)
2020-12-18 14:15 ` ericonr
@ 2020-12-18 14:16 ` ericonr
2020-12-18 14:18 ` ericonr
` (13 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-12-18 14:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#discussion_r545857188
Comment:
The hard limit is 6 hours. What we consider acceptable usage of workers, I don't know. Around 2h perhaps?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (8 preceding siblings ...)
2020-12-18 14:16 ` ericonr
@ 2020-12-18 14:18 ` ericonr
2020-12-21 11:39 ` [PR PATCH] [Updated] " Piraty
` (12 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-12-18 14:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#issuecomment-748107730
Comment:
How do you feel about adding an item for "if this is a new package, explain why it should be packaged"?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (10 preceding siblings ...)
2020-12-21 11:39 ` [PR PATCH] [Updated] " Piraty
@ 2020-12-21 11:39 ` Piraty
2020-12-21 11:40 ` Piraty
` (10 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: Piraty @ 2020-12-21 11:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#discussion_r546659406
Comment:
thanks
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (9 preceding siblings ...)
2020-12-18 14:18 ` ericonr
@ 2020-12-21 11:39 ` Piraty
2020-12-21 11:39 ` [PR REVIEW] " Piraty
` (11 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: Piraty @ 2020-12-21 11:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
There is an updated pull request by Piraty against master on the void-packages repository
https://github.com/Piraty/void-packages github-pr-template
https://github.com/void-linux/void-packages/pull/15798
.github: add pull request template
A patch file from https://github.com/void-linux/void-packages/pull/15798.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-pr-template-15798.patch --]
[-- Type: text/x-diff, Size: 1607 bytes --]
From 71320df43b716f14c2546cf7894c6ae1c89ddb3f Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Sat, 26 Oct 2019 00:56:58 +0200
Subject: [PATCH] .github: add pull request template
---
.github/pull_request_template.md | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 .github/pull_request_template.md
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 00000000000..d69fff435b9
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,23 @@
+<!-- Mark items with [x] where applicable -->
+#### Have the results of the proposed changes been tested?
+- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
+- [ ] I generally don't use the affected packages but briefly tested this PR
+
+<!--
+If GitHub CI cannot be used to validate the build result (for example, if the
+build is likely to take several hours), make sure to include "[ci skip]' in
+either the PR title or this description. When skipping CI, uncomment and complete
+the following section.
+Note: for builds that are likely to complete in less than 2 hours, it is not
+acceptable to skip CI.
+-->
+
+<!--
+#### Does it build and run successfully?
+(Please choose at least one native build and, if supported, at least one cross build. More are better.)
+- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
+- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
+ - [ ] aarch64-musl
+ - [ ] armv7l
+ - [ ] armv6l-musl
+-->
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (11 preceding siblings ...)
2020-12-21 11:39 ` [PR REVIEW] " Piraty
@ 2020-12-21 11:40 ` Piraty
2020-12-21 11:42 ` Piraty
` (9 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: Piraty @ 2020-12-21 11:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#discussion_r546659575
Comment:
thanks!
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (12 preceding siblings ...)
2020-12-21 11:40 ` Piraty
@ 2020-12-21 11:42 ` Piraty
2020-12-21 12:33 ` ericonr
` (8 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: Piraty @ 2020-12-21 11:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#issuecomment-748930994
Comment:
> How do you feel about adding an item for "if this is a new package, explain why it should be packaged"?
what do you expect people to fill in? `i use this package, so i want Void to ship it` ?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (13 preceding siblings ...)
2020-12-21 11:42 ` Piraty
@ 2020-12-21 12:33 ` ericonr
2020-12-21 13:07 ` Piraty
` (7 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-12-21 12:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#issuecomment-748951283
Comment:
Maybe a better wording would be "how does the package fit our packaging guidelines?" ?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (14 preceding siblings ...)
2020-12-21 12:33 ` ericonr
@ 2020-12-21 13:07 ` Piraty
2020-12-21 13:07 ` Piraty
` (6 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: Piraty @ 2020-12-21 13:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 292 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#issuecomment-748964490
Comment:
how about ?
> this new package meets the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (15 preceding siblings ...)
2020-12-21 13:07 ` Piraty
@ 2020-12-21 13:07 ` Piraty
2020-12-21 14:37 ` ericonr
` (5 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: Piraty @ 2020-12-21 13:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#issuecomment-748964490
Comment:
how about ?
> [ ] this new package meets the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (16 preceding siblings ...)
2020-12-21 13:07 ` Piraty
@ 2020-12-21 14:37 ` ericonr
2020-12-21 14:45 ` [PR PATCH] [Updated] " Piraty
` (4 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2020-12-21 14:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#issuecomment-749005635
Comment:
Sounds good.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (17 preceding siblings ...)
2020-12-21 14:37 ` ericonr
@ 2020-12-21 14:45 ` Piraty
2020-12-21 15:03 ` Piraty
` (3 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: Piraty @ 2020-12-21 14:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
There is an updated pull request by Piraty against master on the void-packages repository
https://github.com/Piraty/void-packages github-pr-template
https://github.com/void-linux/void-packages/pull/15798
.github: add pull request template
A patch file from https://github.com/void-linux/void-packages/pull/15798.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-pr-template-15798.patch --]
[-- Type: text/x-diff, Size: 1768 bytes --]
From be768b3cc2f0fb2ca0d599c05f7bb8bc10495a8d Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Sat, 26 Oct 2019 00:56:58 +0200
Subject: [PATCH] .github: add pull request template
---
.github/pull_request_template.md | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 .github/pull_request_template.md
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 00000000000..a1a0213e32e
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,23 @@
+<!-- Mark items with [x] where applicable -->
+#### Have the results of the proposed changes been tested?
+- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
+- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
+- [ ] I generally don't use the affected packages but briefly tested this PR
+
+<!--
+If GitHub CI cannot be used to validate the build result (for example, if the
+build is likely to take several hours), make sure to include "[ci skip]' in
+either the PR title or this description. When skipping CI, uncomment and complete
+the following section.
+Note: for builds that are likely to complete in less than 2 hours, it is not
+acceptable to skip CI.
+-->
+<!--
+#### Does it build and run successfully?
+(Please choose at least one native build and, if supported, at least one cross build. More are better.)
+- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
+- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
+ - [ ] aarch64-musl
+ - [ ] armv7l
+ - [ ] armv6l-musl
+-->
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (18 preceding siblings ...)
2020-12-21 14:45 ` [PR PATCH] [Updated] " Piraty
@ 2020-12-21 15:03 ` Piraty
2020-12-21 15:03 ` Piraty
` (2 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: Piraty @ 2020-12-21 15:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
There is an updated pull request by Piraty against master on the void-packages repository
https://github.com/Piraty/void-packages github-pr-template
https://github.com/void-linux/void-packages/pull/15798
.github: add pull request template
A patch file from https://github.com/void-linux/void-packages/pull/15798.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-pr-template-15798.patch --]
[-- Type: text/x-diff, Size: 1804 bytes --]
From de3c522b15db7432e09ee18d1c5249f6209b608e Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Sat, 26 Oct 2019 00:56:58 +0200
Subject: [PATCH] .github: add pull request template
---
.github/pull_request_template.md | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
create mode 100644 .github/pull_request_template.md
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 00000000000..212d2ef3f78
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,28 @@
+<!-- Mark items with [x] where applicable -->
+
+#### General
+- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
+
+#### Have the results of the proposed changes been tested?
+- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
+- [ ] I generally don't use the affected packages but briefly tested this PR
+
+<!--
+If GitHub CI cannot be used to validate the build result (for example, if the
+build is likely to take several hours), make sure to include "[ci skip]' in
+either the PR title or this description. When skipping CI, uncomment and complete
+the following section.
+Note: for builds that are likely to complete in less than 2 hours, it is not
+acceptable to skip CI.
+-->
+<!--
+#### Does it build and run successfully?
+(Please choose at least one native build and, if supported, at least one cross build. More are better.)
+- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
+- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
+ - [ ] aarch64-musl
+ - [ ] armv7l
+ - [ ] armv6l-musl
+
+[ci skip]
+-->
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (19 preceding siblings ...)
2020-12-21 15:03 ` Piraty
@ 2020-12-21 15:03 ` Piraty
2020-12-30 7:29 ` the-maldridge
2021-01-18 12:17 ` [PR PATCH] [Merged]: " Piraty
22 siblings, 0 replies; 24+ messages in thread
From: Piraty @ 2020-12-21 15:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#issuecomment-749018731
Comment:
next round of review
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (20 preceding siblings ...)
2020-12-21 15:03 ` Piraty
@ 2020-12-30 7:29 ` the-maldridge
2021-01-18 12:17 ` [PR PATCH] [Merged]: " Piraty
22 siblings, 0 replies; 24+ messages in thread
From: the-maldridge @ 2020-12-30 7:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/15798#issuecomment-752359077
Comment:
I am relatively satisfied with this PR. If there are no further concerns I will merge it on Friday.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Merged]: .github: add pull request template
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
` (21 preceding siblings ...)
2020-12-30 7:29 ` the-maldridge
@ 2021-01-18 12:17 ` Piraty
22 siblings, 0 replies; 24+ messages in thread
From: Piraty @ 2021-01-18 12:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
There's a merged pull request on the void-packages repository
.github: add pull request template
https://github.com/void-linux/void-packages/pull/15798
Description:
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2021-01-18 12:17 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 23:14 [PR PATCH] .github: add pull request template voidlinux-github
2019-10-26 5:06 ` voidlinux-github
2019-10-27 15:52 ` [PR PATCH] [Updated] " voidlinux-github
2019-10-27 15:52 ` voidlinux-github
2020-11-15 13:41 ` Piraty
2020-12-18 14:14 ` [PR REVIEW] " ahesford
2020-12-18 14:14 ` ahesford
2020-12-18 14:14 ` ahesford
2020-12-18 14:15 ` ericonr
2020-12-18 14:16 ` ericonr
2020-12-18 14:18 ` ericonr
2020-12-21 11:39 ` [PR PATCH] [Updated] " Piraty
2020-12-21 11:39 ` [PR REVIEW] " Piraty
2020-12-21 11:40 ` Piraty
2020-12-21 11:42 ` Piraty
2020-12-21 12:33 ` ericonr
2020-12-21 13:07 ` Piraty
2020-12-21 13:07 ` Piraty
2020-12-21 14:37 ` ericonr
2020-12-21 14:45 ` [PR PATCH] [Updated] " Piraty
2020-12-21 15:03 ` Piraty
2020-12-21 15:03 ` Piraty
2020-12-30 7:29 ` the-maldridge
2021-01-18 12:17 ` [PR PATCH] [Merged]: " Piraty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).