From: Piraty <Piraty@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] .github: add notice to delete the [ci skip] block
Date: Mon, 18 Jan 2021 14:43:04 +0100 [thread overview]
Message-ID: <20210118134304.se8mE771orktmL3RdrQlC9_6vsy9EagIskmXpOSVzJg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28010@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 361 bytes --]
There is an updated pull request by Piraty against master on the void-packages repository
https://github.com/Piraty/void-packages pr-template-add-deletion-notice
https://github.com/void-linux/void-packages/pull/28010
.github: add notice to delete the [ci skip] block
A patch file from https://github.com/void-linux/void-packages/pull/28010.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr-template-add-deletion-notice-28010.patch --]
[-- Type: text/x-diff, Size: 1306 bytes --]
From 72fe7bc43d6672d7d9252e3c2fe8fdf0ec0098c6 Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Mon, 18 Jan 2021 14:01:24 +0100
Subject: [PATCH] .github: add notice to delete the [ci skip] block
if the commented block is left in the PR text, CI won't run
---
.github/pull_request_template.md | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 212d2ef3f78..1fdf9e94ea9 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -9,9 +9,9 @@
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
-build is likely to take several hours), make sure to include "[ci skip]' in
-either the PR title or this description. When skipping CI, uncomment and complete
-the following section.
+build is likely to take several hours), make sure to
+[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
+When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
@@ -23,6 +23,4 @@ acceptable to skip CI.
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-
-[ci skip]
-->
next prev parent reply other threads:[~2021-01-18 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 13:02 [PR PATCH] " Piraty
2021-01-18 13:03 ` [PR PATCH] [Updated] " Piraty
2021-01-18 13:26 ` ahesford
2021-01-18 13:43 ` Piraty [this message]
2021-01-18 14:01 ` [PR PATCH] [Merged]: " Piraty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118134304.se8mE771orktmL3RdrQlC9_6vsy9EagIskmXpOSVzJg@z \
--to=piraty@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).