[PR PATCH] .github: add notice to delete the [ci skip] block

[PR PATCH] .github: add notice to delete the [ci skip] block

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

There is a new pull request by Piraty against master on the void-packages repository

https://github.com/Piraty/void-packages pr-template-add-deletion-notice
https://github.com/void-linux/void-packages/pull/28010

.github: add notice to delete the [ci skip] block


A patch file from https://github.com/void-linux/void-packages/pull/28010.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr-template-add-deletion-notice-28010.patch --]
[-- Type: text/x-diff, Size: 992 bytes --]

From a9aff04b8d29485f1f3cc2c40a613436c9e4e537 Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Mon, 18 Jan 2021 14:01:24 +0100
Subject: [PATCH] .github: add notice to delete the [ci skip] block

---
 .github/pull_request_template.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 212d2ef3f78..d131c59aadc 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -7,7 +7,7 @@
 - [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
 - [ ] I generally don't use the affected packages but briefly tested this PR
 
-<!--
+<!-- DELETE BELOW BLOCK IF NOT REQUIRED
 If GitHub CI cannot be used to validate the build result (for example, if the
 build is likely to take several hours), make sure to include "[ci skip]' in
 either the PR title or this description. When skipping CI, uncomment and complete

Re: [PR PATCH] [Updated] .github: add notice to delete the [ci skip] block

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

There is an updated pull request by Piraty against master on the void-packages repository

https://github.com/Piraty/void-packages pr-template-add-deletion-notice
https://github.com/void-linux/void-packages/pull/28010

.github: add notice to delete the [ci skip] block


A patch file from https://github.com/void-linux/void-packages/pull/28010.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr-template-add-deletion-notice-28010.patch --]
[-- Type: text/x-diff, Size: 1052 bytes --]

From b32a51b47e1938f8de3ffa35d89ff157919af406 Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Mon, 18 Jan 2021 14:01:24 +0100
Subject: [PATCH] .github: add notice to delete the [ci skip] block

if the commented block is left in the PR text, CI won't run
---
 .github/pull_request_template.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 212d2ef3f78..d131c59aadc 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -7,7 +7,7 @@
 - [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
 - [ ] I generally don't use the affected packages but briefly tested this PR
 
-<!--
+<!-- DELETE BELOW BLOCK IF NOT REQUIRED
 If GitHub CI cannot be used to validate the build result (for example, if the
 build is likely to take several hours), make sure to include "[ci skip]' in
 either the PR title or this description. When skipping CI, uncomment and complete

Re: .github: add notice to delete the [ci skip] block

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/28010#issuecomment-762249597

Comment:
Maybe we should include CI skip directions in the manual or some readme file and link to it here rather than including the literal `[ci skip]` here and relying on people to remove it.

Something like, in Markdown link syntax, "... make sure to [skip CI] (some/doc/URL)". 

Re: [PR PATCH] [Updated] .github: add notice to delete the [ci skip] block

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

There is an updated pull request by Piraty against master on the void-packages repository

https://github.com/Piraty/void-packages pr-template-add-deletion-notice
https://github.com/void-linux/void-packages/pull/28010

.github: add notice to delete the [ci skip] block


A patch file from https://github.com/void-linux/void-packages/pull/28010.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr-template-add-deletion-notice-28010.patch --]
[-- Type: text/x-diff, Size: 1306 bytes --]

From 72fe7bc43d6672d7d9252e3c2fe8fdf0ec0098c6 Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Mon, 18 Jan 2021 14:01:24 +0100
Subject: [PATCH] .github: add notice to delete the [ci skip] block

if the commented block is left in the PR text, CI won't run
---
 .github/pull_request_template.md | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 212d2ef3f78..1fdf9e94ea9 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -9,9 +9,9 @@
 
 <!--
 If GitHub CI cannot be used to validate the build result (for example, if the
-build is likely to take several hours), make sure to include "[ci skip]' in
-either the PR title or this description. When skipping CI, uncomment and complete
-the following section.
+build is likely to take several hours), make sure to
+[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
+When skipping CI, uncomment and fill out the following section.
 Note: for builds that are likely to complete in less than 2 hours, it is not
 acceptable to skip CI.
 -->
@@ -23,6 +23,4 @@ acceptable to skip CI.
   - [ ] aarch64-musl
   - [ ] armv7l
   - [ ] armv6l-musl
-
-[ci skip]
 -->

Re: [PR PATCH] [Merged]: .github: add notice to delete the [ci skip] block

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

There's a merged pull request on the void-packages repository

.github: add notice to delete the [ci skip] block
https://github.com/void-linux/void-packages/pull/28010

Description: