From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] gstreamer1: update to 1.18.3.
Date: Tue, 19 Jan 2021 17:10:49 +0100 [thread overview]
Message-ID: <20210119161049.WOl7rAxPihs4YKjPOho3hxDjpPC3OVDXXAZ2S20yRCY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27996@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/27996#discussion_r560296090
Comment:
Note that the current version of the `gst-omx` package seems to define `$(BRCMEGL_LIBS)` and `$(BRCMEGL_CFLAGS)` from `pkg-config`, but the Makefiles it produces don't actually use these variables. This is confirmed by looking at the dependencies of the `gst-omx` package for `armv7l`, which has no dependency on `rpi-userland` because the plugin does not link against any of the libraries provided by `rpi-userland`.
Unless the move to meson happened to fix linking against these libraries, I think dropping the `rpi` build option is the right call.
next prev parent reply other threads:[~2021-01-19 16:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 22:56 [PR PATCH] " travankor
2021-01-17 22:57 ` [PR PATCH] [Updated] " travankor
2021-01-17 23:00 ` mobinmob
2021-01-17 23:01 ` mobinmob
2021-01-17 23:12 ` travankor
2021-01-18 12:18 ` [PR PATCH] [Updated] " travankor
2021-01-18 12:27 ` travankor
2021-01-18 12:38 ` ahesford
2021-01-18 12:57 ` [PR PATCH] [Updated] " travankor
2021-01-18 21:32 ` travankor
2021-01-19 7:19 ` travankor
2021-01-19 15:12 ` [PR REVIEW] " not-chicken
2021-01-19 15:20 ` ahesford
2021-01-19 15:56 ` not-chicken
2021-01-19 16:10 ` ahesford [this message]
2021-01-26 4:19 ` ericonr
2021-01-26 10:39 ` pullmoll
2021-01-26 13:22 ` [PR PATCH] [Updated] " travankor
2021-01-26 13:25 ` travankor
2021-01-26 15:03 ` pullmoll
2021-01-26 15:11 ` pullmoll
2021-01-27 6:49 ` travankor
2021-02-03 4:23 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119161049.WOl7rAxPihs4YKjPOho3hxDjpPC3OVDXXAZ2S20yRCY@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).