From: tibequadorian <tibequadorian@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: newsboat: update to 2.22.1.
Date: Wed, 20 Jan 2021 03:03:52 +0100 [thread overview]
Message-ID: <20210120020352.SV0jnryw-qb2XX2yJPSK_O354rvEZw-5kJGH_94nVOw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27902@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/27902#issuecomment-763276139
Comment:
> @tibequadorian do you think the changes from `post_patch` in https://github.com/tibequadorian/void-packages/pull/5/files are necessary?
On @Minoru suggestion in https://github.com/tibequadorian/void-packages/pull/5#discussion_r555127025 I set `make_check_target=ci-check` and removed current `do_check` from the template. This fails with "Error opening terminal: unknown."
However the `ci-check` target in the Makefile looks quite similar to what was in the `do_check` function, so I kinda merged the idea in `post_patch` and checks were indeed successful, but the CI still fails.
next prev parent reply other threads:[~2021-01-20 2:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 20:57 [PR PATCH] " subsonik
2021-01-13 21:28 ` Minoru
2021-01-13 22:01 ` subsonik
2021-01-20 0:19 ` ericonr
2021-01-20 2:03 ` tibequadorian
2021-01-20 2:03 ` tibequadorian [this message]
2021-01-20 2:04 ` tibequadorian
2021-01-20 2:06 ` tibequadorian
2021-02-18 2:51 ` [PR PATCH] [Closed]: " ericonr
2021-02-16 22:09 [PR PATCH] " tibequadorian
2021-02-17 14:49 ` ericonr
2021-02-17 19:46 ` Minoru
2021-02-17 20:17 ` ericonr
2021-02-17 23:29 ` tibequadorian
2021-02-17 23:29 ` tibequadorian
2021-02-18 1:06 ` ericonr
2021-02-18 1:06 ` ericonr
2021-02-18 1:14 ` tibequadorian
2021-02-18 1:16 ` tibequadorian
2021-02-18 1:17 ` tibequadorian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120020352.SV0jnryw-qb2XX2yJPSK_O354rvEZw-5kJGH_94nVOw@z \
--to=tibequadorian@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).