Re: [PR PATCH] [Updated] pipewire: add support for aptx and aac

[paper42 <paper42@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pipewire-aptx-aac
https://github.com/void-linux/void-packages/pull/28145

pipewire: add support for aptx and aac
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

@st3r4g 
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28145.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-aptx-aac-28145.patch --]
[-- Type: text/x-diff, Size: 3293 bytes --]

From ab52861a9ce9ebedb1636b211ddd1a10dd23fedc Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sun, 24 Jan 2021 14:22:01 +0100
Subject: [PATCH 1/2] New package: libopenaptx-0.2.0.

---
 common/shlibs                |  1 +
 srcpkgs/libopenaptx-devel    |  1 +
 srcpkgs/libopenaptx/template | 21 +++++++++++++++++++++
 3 files changed, 23 insertions(+)
 create mode 120000 srcpkgs/libopenaptx-devel
 create mode 100644 srcpkgs/libopenaptx/template

diff --git a/common/shlibs b/common/shlibs
index 8c6b5d9d014..e8d28aed488 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4044,3 +4044,4 @@ libutil-cmdline-samba4.so samba-libs-4.13.2_1
 libwinbind-client-samba4.so samba-libs-4.13.2_1
 libsixel.so.1 libsixel-1.8.6_1
 libpamtest.so.0 pam_wrapper-1.1.3_1
+libopenaptx.so.0 libopenaptx-0.2.0_1
diff --git a/srcpkgs/libopenaptx-devel b/srcpkgs/libopenaptx-devel
new file mode 120000
index 00000000000..2791f43ede1
--- /dev/null
+++ b/srcpkgs/libopenaptx-devel
@@ -0,0 +1 @@
+libopenaptx
\ No newline at end of file
diff --git a/srcpkgs/libopenaptx/template b/srcpkgs/libopenaptx/template
new file mode 100644
index 00000000000..aaa4b430a5c
--- /dev/null
+++ b/srcpkgs/libopenaptx/template
@@ -0,0 +1,21 @@
+# Template file for 'libopenaptx'
+pkgname=libopenaptx
+version=0.2.0
+revision=1
+build_style=gnu-makefile
+short_desc="Open Source implementation of Audio Processing Technology codec (aptX)"
+maintainer="Paper <paper@tilde.institute>"
+license="LGPL-2.1-or-later"
+homepage="https://github.com/pali/libopenaptx/"
+distfiles="https://github.com/pali/libopenaptx/releases/download/${version}/libopenaptx-${version}.tar.gz"
+checksum=51a13a34bb188a87ab1deb64a090ab42a4755d7b02c2bdaf3b8136f749b71b84
+
+libopenaptx-devel_package() {
+	depends="libopenaptx>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove usr/lib/pkgconfig
+		vmove usr/lib/*.so
+	}
+}

From 98e8dbb0d867af08f746130204ea578eb86908e8 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sun, 24 Jan 2021 14:47:46 +0100
Subject: [PATCH 2/2] pipewire: add support for aptx and aac

---
 srcpkgs/pipewire/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 79a4d0e28b5..ff6b72147ee 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,14 +1,15 @@
 # Template file for 'pipewire'
 pkgname=pipewire
 version=0.3.20
-revision=1
+revision=2
 build_style=meson
 configure_args="-Dman=true -Dgstreamer=true -Ddocs=true -Dsystemd=false
  -Dbluez5=true -Dffmpeg=true -Dpipewire-alsa=true -Dpipewire-jack=true
  -Dudevrulesdir=/usr/lib/udev/rules.d"
-hostmakedepends="doxygen graphviz pkg-config xmltoman"
+hostmakedepends="doxygen graphviz pkg-config xmltoman gettext"
 makedepends="SDL2-devel ffmpeg-devel gst-plugins-base1-devel jack-devel
- sbc-devel v4l-utils-devel libva-devel libbluetooth-devel ncurses-devel"
+ sbc-devel v4l-utils-devel libva-devel libbluetooth-devel ncurses-devel
+ libopenaptx-devel fdk-aac-devel"
 depends="libspa-alsa libspa-audioconvert libspa-audiomixer libspa-control"
 short_desc="Server and user space API to deal with multimedia pipelines"
 maintainer="Kridsada Thanabulpong <sirn@ogsite.net>"