From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Mediainfo
Date: Wed, 27 Jan 2021 23:25:20 +0100 [thread overview]
Message-ID: <20210127222520.fvG5412SPfEI3OUeDFua3fGi6ZT6PhPvihbmkoAOKVg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27936@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27936#issuecomment-768619214
Comment:
> We would like to have a method which is fine for you but at the same time fine for platforms not having gmtime_r (and also as multithread is not always used, if we can avoid a mutex... I am aware that it is a lot of conditions).
It would be pretty complicated (and error prone) to build one version of the library for the MT or not case, so always using `gmtime_r` is the least bad alternative. It also shouldn't use a mutex, since the second argument allows it to simply not use any globals.
> IIUC doing that will make gmtime_r available in your case but will at the same time create issues on platforms not having gmtime_r, something we are actually trying to avoid.
Do you know of any platforms that don't have it, besides Windows? (For which you already have an ifdef block).
next prev parent reply other threads:[~2021-01-27 22:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 20:55 [PR PATCH] Mediainfo gspe
2021-01-14 20:59 ` Mediainfo q66
2021-01-14 21:19 ` Mediainfo ericonr
2021-01-14 21:21 ` Mediainfo ericonr
2021-01-14 21:21 ` Mediainfo ericonr
2021-01-14 21:33 ` Mediainfo ericonr
2021-01-14 21:42 ` Mediainfo ericonr
2021-01-14 21:42 ` Mediainfo ericonr
2021-01-14 21:43 ` Mediainfo ericonr
2021-01-15 8:05 ` [PR PATCH] [Updated] Mediainfo gspe
2021-01-26 3:05 ` Mediainfo ericonr
2021-01-27 21:39 ` Mediainfo JeromeMartinez
2021-01-27 22:25 ` ericonr [this message]
2021-01-27 22:56 ` Mediainfo ericonr
2021-02-15 3:47 ` [PR PATCH] [Closed]: Mediainfo ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127222520.fvG5412SPfEI3OUeDFua3fGi6ZT6PhPvihbmkoAOKVg@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).