From: kawaiiamber <kawaiiamber@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: minipro-0.5
Date: Sat, 30 Jan 2021 01:44:01 +0100 [thread overview]
Message-ID: <20210130004401.yJKPnDAZtbO2Qpus7UuiwoD7EgO8twi7EcPUMdD4H7o@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27855@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
New review comment by kawaiiamber on void-packages repository
https://github.com/void-linux/void-packages/pull/27855#discussion_r567166327
Comment:
Line 49 of their Makefile uses `which` to check for pkg-config, which needs to be added in cross build:
```
if [ "${CROSS_BUILD}" ]; then
hostmakedepends+=" which"
fi
```
This fixes one error when I tested on aarch64-musl, but other error occurs that I'm still working out.
next prev parent reply other threads:[~2021-01-30 0:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 10:23 [PR PATCH] " jleightcap
2021-01-30 0:44 ` kawaiiamber [this message]
2021-01-30 0:44 ` [PR REVIEW] " kawaiiamber
2021-04-02 18:19 ` [PR PATCH] [Updated] " jleightcap
2022-05-02 2:16 ` github-actions
2022-05-17 2:13 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210130004401.yJKPnDAZtbO2Qpus7UuiwoD7EgO8twi7EcPUMdD4H7o@z \
--to=kawaiiamber@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).