From: Johnnynator <Johnnynator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: singularity-3.7.1
Date: Sun, 31 Jan 2021 00:29:27 +0100 [thread overview]
Message-ID: <20210130232927.EqwNk8Jk4zm2O81HpufCLChsn7ZauEqIucD5SGzJ5Uw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28129@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
New review comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/28129#discussion_r567335991
Comment:
```suggestion
post)
if [ "$(readlink -f . 2>/dev/null || echo .)" != "/" ]; then
exit 1
else
mkdir -p var/lib/singularity/mnt/session
chown root:_singularity usr/libexec/singularity/bin/starter-suid
chmod 4755 usr/libexec/singularity/bin/starter-suid
fi
```
Maybe do smth like this to prevent changing the binary to a potentially wrong group when executing xbps-install with `--rootidr`
next prev parent reply other threads:[~2021-01-30 23:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 23:58 [PR PATCH] [WIP] " olafmersmann
2021-01-24 20:34 ` [PR PATCH] [Updated] " olafmersmann
2021-01-26 2:29 ` [PR REVIEW] " ericonr
2021-01-26 2:29 ` ericonr
2021-01-26 2:29 ` ericonr
2021-01-26 2:29 ` ericonr
2021-01-26 2:29 ` ericonr
2021-01-26 2:29 ` ericonr
2021-01-26 2:29 ` ericonr
2021-01-26 2:29 ` ericonr
2021-01-27 23:16 ` olafmersmann
2021-01-27 23:16 ` olafmersmann
2021-01-27 23:17 ` olafmersmann
2021-01-27 23:21 ` olafmersmann
2021-01-27 23:25 ` olafmersmann
2021-01-27 23:30 ` ericonr
2021-01-27 23:34 ` olafmersmann
2021-01-27 23:35 ` olafmersmann
2021-01-27 23:39 ` olafmersmann
2021-01-27 23:41 ` [PR PATCH] [Updated] " olafmersmann
2021-01-27 23:47 ` [PR REVIEW] " ericonr
2021-01-27 23:53 ` [PR PATCH] [Updated] " olafmersmann
2021-01-27 23:54 ` [PR REVIEW] " olafmersmann
2021-01-28 0:04 ` ericonr
2021-01-28 0:15 ` [PR PATCH] [Updated] " olafmersmann
2021-01-28 0:15 ` [PR REVIEW] " olafmersmann
2021-01-28 0:21 ` [PR PATCH] [Updated] " olafmersmann
2021-01-30 23:29 ` Johnnynator [this message]
2021-01-30 23:34 ` [PR REVIEW] " ericonr
2021-01-30 23:34 ` ericonr
2021-01-30 23:48 ` [PR PATCH] [Updated] " olafmersmann
2021-01-30 23:50 ` [PR REVIEW] " olafmersmann
2021-01-31 2:08 ` ericonr
2021-01-31 2:16 ` Johnnynator
2022-05-02 2:16 ` github-actions
2022-05-17 2:13 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210130232927.EqwNk8Jk4zm2O81HpufCLChsn7ZauEqIucD5SGzJ5Uw@z \
--to=johnnynator@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).