Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [WiP] build-style/cmake: use ninja as default generator
Date: Sun, 31 Jan 2021 03:16:20 +0100	[thread overview]
Message-ID: <20210131021620.wuhEfNm0e6n9ShruHahftvpxKFyrfqL0s-nvgCrr40E@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28304@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28304#discussion_r567352216

Comment:
`cmake-bootstrap` doesn't know how to generate Ninja, so I'll add `-G'Unix Makefiles'` to `cmake`'s `configure_args`

  parent reply	other threads:[~2021-01-31  2:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29 15:28 [PR PATCH] " Johnnynator
2021-01-29 15:30 ` [PR PATCH] [Updated] " Johnnynator
2021-01-29 15:40 ` ericonr
2021-01-29 15:47 ` [PR PATCH] [Updated] " Johnnynator
2021-01-30  0:32 ` [PR REVIEW] " sgn
2021-01-30  0:35 ` Johnnynator
2021-01-31  2:13 ` sgn
2021-01-31  2:16 ` sgn [this message]
2021-01-31  2:30 ` sgn
2021-01-31  2:32 ` ericonr
2021-01-31  2:46 ` ericonr
2021-01-31  2:47 ` ericonr
2021-02-05  9:03 ` sgn
2021-02-08 10:50 ` Johnnynator
2021-02-08 23:15 ` [PR PATCH] [Updated] " Johnnynator
2021-02-08 23:20 ` [PR PATCH] [Closed]: " Johnnynator

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210131021620.wuhEfNm0e6n9ShruHahftvpxKFyrfqL0s-nvgCrr40E@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).