From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] eiskaltdcpp-qt: update to 2.4.1
Date: Sun, 31 Jan 2021 04:38:09 +0100 [thread overview]
Message-ID: <20210131033809.4VHeB8lRAMkgmxwHY1cB-NswgPsTmwew3_FQccUugYQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28328@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28328#discussion_r567359352
Comment:
For the record, when dealing with execinfo.h, it's a bit more correct to check for glibc, since execinfo.h is not a standard. You will have to add any new platform you port this to the list of conditionals you check, instead of just potentially missing some functionality there. Even better would be to see if the function exists, which should be reaasonably simple, given that you are using CMake. I have an example of checking for a function here: https://github.com/MediaArea/ZenLib/pull/126
next prev parent reply other threads:[~2021-01-31 3:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 9:37 [PR PATCH] " tehnick
2021-01-30 9:45 ` [PR PATCH] [Updated] " tehnick
2021-01-30 9:46 ` tehnick
2021-01-30 10:02 ` tehnick
2021-01-30 10:07 ` tehnick
2021-01-30 12:40 ` tehnick
2021-01-30 13:18 ` tehnick
2021-01-30 13:29 ` tehnick
2021-01-30 13:37 ` tehnick
2021-01-30 13:44 ` tehnick
2021-01-31 3:38 ` ericonr [this message]
2021-01-31 3:46 ` [PR REVIEW] " ericonr
2021-01-31 9:26 ` tehnick
2021-01-31 9:26 ` [PR PATCH] [Updated] " tehnick
2021-01-31 9:26 ` tehnick
2021-01-31 9:27 ` tehnick
2021-01-31 9:27 ` [PR REVIEW] " tehnick
2021-01-31 9:28 ` tehnick
2021-01-31 13:42 ` [PR PATCH] [Updated] " tehnick
2021-01-31 13:52 ` tehnick
2021-01-31 13:52 ` tehnick
2021-01-31 13:54 ` [PR PATCH] [Updated] " tehnick
2021-01-31 18:34 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210131033809.4VHeB8lRAMkgmxwHY1cB-NswgPsTmwew3_FQccUugYQ@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).