Github messages for voidlinux
 help / color / mirror / Atom feed
From: jarda-wien <jarda-wien@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: testdisk: Add missing ncurses-base dependency
Date: Mon, 01 Feb 2021 13:21:18 +0100	[thread overview]
Message-ID: <20210201122118.C_eionAtW1OYmD2WVE8O0NvJqqFZWAdTH41DMV2mRQ0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28377@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1409 bytes --]

New comment by jarda-wien on void-packages repository

https://github.com/void-linux/void-packages/pull/28377#issuecomment-770816779

Comment:
> The consensus is that packages shouldn't depend on ncurses-base, packages use some terminfo that can't be expressed as dependency as it depends on your TERM variable. Generally ncurses-base should be installed as part of the base system i.e. the base-system metapackage, it's deliberately not part of base-minimal as it would increase container sizes. If we would start to add ncurses-base to everything that might need it, we would effectively add it to base-minimal as i.e. util-linux's cfdisk "depends" on terminfo descriptions.

My main use case for the testdisk package was having it in a minimal docker container, so I didn't have "base-system" installed. While I understand the reasoning behind *the consensus*, I am not sure if we have any means of at least warning the user that something is missing. Being mostly on archlinux systems, I am not very seasoned in metadata fields provided by void packages. I tried googling something like optional dependecies and came across [this](https://github.com/void-linux/xbps/issues/1).

Please point me to some preferred possibility of informing the user that something is missing in the current environment. If there is no such tool available, I guess you can reject this PR and keep things the way they are.

  parent reply	other threads:[~2021-02-01 12:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 10:13 [PR PATCH] " jarda-wien
2021-02-01 10:17 ` jarda-wien
2021-02-01 10:19 ` jarda-wien
2021-02-01 10:41 ` FollieHiyuki
2021-02-01 10:42 ` FollieHiyuki
2021-02-01 10:45 ` [PR PATCH] [Updated] " jarda-wien
2021-02-01 10:47 ` jarda-wien
2021-02-01 10:48 ` jarda-wien
2021-02-01 11:10 ` Duncaen
2021-02-01 11:10 ` Duncaen
2021-02-01 12:21 ` jarda-wien [this message]
2021-02-01 13:34 ` sgn
2021-02-02 23:41 ` [PR PATCH] [Closed]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210201122118.C_eionAtW1OYmD2WVE8O0NvJqqFZWAdTH41DMV2mRQ0@z \
    --to=jarda-wien@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).