From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: python3-adblock-0.4.2
Date: Mon, 01 Feb 2021 22:14:37 +0100 [thread overview]
Message-ID: <20210201211437.Stbo46bk03BqGG9NDR_7ntDpm03AXgaV2LxU6yiPkh4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28396@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28396#discussion_r568141069
Comment:
Does this make it link in static openssl? <-- just checked, the final package doesn't depend on any dynamic libraries besides musl and libgcc
Also, can you add a `# FIXME` about the issue/where you found the workaround?
next prev parent reply other threads:[~2021-02-01 21:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 21:01 [PR PATCH] " ahesford
2021-02-01 21:02 ` ahesford
2021-02-01 21:09 ` [PR REVIEW] " ericonr
2021-02-01 21:10 ` ahesford
2021-02-01 21:14 ` ericonr [this message]
2021-02-01 21:15 ` ericonr
2021-02-01 21:22 ` ericonr
2021-02-01 21:23 ` ericonr
2021-02-01 21:24 ` ericonr
2021-02-01 21:25 ` ericonr
2021-02-01 21:35 ` ericonr
2021-02-01 21:46 ` ericonr
2021-02-01 21:48 ` ericonr
2021-02-02 1:42 ` ericonr
2021-02-02 15:34 ` [PR PATCH] [Updated] " ahesford
2021-02-02 15:49 ` ahesford
2021-02-03 22:06 ` [PR PATCH] [Updated] " ahesford
2021-02-04 1:23 ` [PR REVIEW] " ericonr
2021-02-04 1:23 ` ericonr
2021-02-04 1:23 ` ericonr
2021-02-04 1:23 ` ericonr
2021-02-04 1:34 ` ericonr
2021-02-04 4:21 ` [PR PATCH] [Updated] " ahesford
2021-02-04 4:22 ` ahesford
2021-02-04 4:25 ` ahesford
2021-02-04 5:33 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201211437.Stbo46bk03BqGG9NDR_7ntDpm03AXgaV2LxU6yiPkh4@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).