Re: [PR PATCH] [Updated] [RFC] environment/configure/hardening: add -Werror=implicit.

[ericonr <ericonr@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1819 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages werror
https://github.com/void-linux/void-packages/pull/28389

[RFC] environment/configure/hardening: add -Werror=implicit.
Warnings for implicit function definitions should be errors, since they
can lead to issues down the line when the implicit type rules get things
wrong, especially with variadic functions.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28389.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-werror-28389.patch --]
[-- Type: text/x-diff, Size: 920 bytes --]

From c80e97f74da3d1311f3b921ae7d8eb3010b6e206 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 1 Feb 2021 12:14:28 -0300
Subject: [PATCH] environment/configure/hardening: add
 -Werror=implicit-function-declaration.

Warnings for implicit function declarations should be errors, since they
can lead to issues down the line when the implicit type rules get things
wrong, especially with variadic functions.
---
 common/environment/configure/hardening.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/environment/configure/hardening.sh b/common/environment/configure/hardening.sh
index 9e02364f2a1..025bb153183 100644
--- a/common/environment/configure/hardening.sh
+++ b/common/environment/configure/hardening.sh
@@ -28,3 +28,5 @@ else
 	FFLAGS="-fno-PIE ${FFLAGS}"
 	LDFLAGS="-no-pie ${LDFLAGS}"
 fi
+
+CFLAGS="${CFLAGS} -Werror=implicit-function-declaration"