From 4c2c719b27107d0d18901b0a6ffd74e6aaf91383 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89rico=20Rolim?= Date: Thu, 28 Jan 2021 01:17:40 -0300 Subject: [PATCH 1/3] meson: update to 0.56.2. Fix checkdepends and tests in general on musl. Add bash completions. --- srcpkgs/meson/patches/fix-unittest.patch | 77 ++++++++++++++++++++++++ srcpkgs/meson/template | 29 ++++++--- 2 files changed, 99 insertions(+), 7 deletions(-) create mode 100644 srcpkgs/meson/patches/fix-unittest.patch diff --git a/srcpkgs/meson/patches/fix-unittest.patch b/srcpkgs/meson/patches/fix-unittest.patch new file mode 100644 index 00000000000..746de056ed7 --- /dev/null +++ b/srcpkgs/meson/patches/fix-unittest.patch @@ -0,0 +1,77 @@ +commit 777cbe9c0faa018bafccf3e7adb8dad162276e35 +Author: Érico Rolim +Date: Mon Feb 1 00:26:49 2021 -0300 + + tests/common: fix " 37 has function" test on musl systems. + + This commit fixes the test that asserts on whether the lchmod() function + should have been detected as available by Meson. It does so by assuming + that on Linux systems not using glibc, the function will be available. + + - fix comment about lchmod on Linux: musl has implemented the function + correctly since 2013, so the assumption in the test wasn't correct. + Furthermore, musl doesn't use glibc's stub mechanism. + - fix include to receive __GLIBC__ definition: including almost any + header in glibc will end up defining __GLIBC__, since most headers + include . The header was probably + chosen because of its name, but its actual purpose is defining functions + for checking glibc version at runtime (instead of what the binary was + built with), so it isn't necessary to use it. Since it is a completely + non standard header, including it makes the test suite fail on musl due + to not finding the header. + +diff --git test cases/common/37 has function/meson.build test cases/common/37 has function/meson.build +index 26f13d6fa..a59480c2d 100644 +--- test cases/common/39 has function/meson.build ++++ test cases/common/39 has function/meson.build +@@ -44,11 +44,13 @@ foreach cc : compilers + error('Found non-existent function "hfkerhisadf".') + endif + +- # With glibc on Linux lchmod is a stub that will always return an error, +- # we want to detect that and declare that the function is not available. +- # We can't check for the C library used here of course, but if it's not +- # implemented in glibc it's probably not implemented in any other 'slimmer' +- # C library variants either, so the check should be safe either way hopefully. ++ # With glibc (before 2.32, see below) on Linux, lchmod is a stub that will ++ # always return an error, we want to detect that and declare that the ++ # function is not available. ++ # We can't check for the C library used here of course, but the main ++ # alternative Linux C library (musl) doesn't use glibc's stub mechanism; ++ # also, it has implemented lchmod since 2013, so it should be safe to check ++ # that lchmod is available on Linux when not using glibc. + if host_system == 'linux' or host_system == 'darwin' + assert (cc.has_function('poll', prefix : '#include ', + args : unit_test_args), +@@ -57,15 +59,24 @@ foreach cc : compilers + has_lchmod = cc.has_function('lchmod', prefix : lchmod_prefix, args : unit_test_args) + + if host_system == 'linux' +- glibc_major = cc.get_define('__GLIBC__', prefix: '#include ', args: unit_test_args) +- glibc_minor = cc.get_define('__GLIBC_MINOR__', prefix: '#include ', args: unit_test_args) +- glibc_vers = '@0@.@1@'.format(glibc_major, glibc_minor) +- message('GLIBC vetsion:', glibc_vers) ++ # __GLIBC__ macro can be retrieved by including almost any C library header ++ glibc_major = cc.get_define('__GLIBC__', prefix: '#include ', args: unit_test_args) ++ # __GLIBC__ will only be set for glibc ++ if glibc_major != '' ++ glibc_print = 'hi "@0@" hi'.format(glibc_major) ++ message(glibc_print) ++ glibc_minor = cc.get_define('__GLIBC_MINOR__', prefix: '#include ', args: unit_test_args) ++ glibc_vers = '@0@.@1@'.format(glibc_major, glibc_minor) ++ message('GLIBC version:', glibc_vers) + +- # lchmod was implemented in glibc 2.32 (https://sourceware.org/pipermail/libc-announce/2020/000029.html) +- if glibc_vers.version_compare('<2.32') +- assert (not has_lchmod, '"lchmod" check should have failed') ++ # lchmod was implemented in glibc 2.32 (https://sourceware.org/pipermail/libc-announce/2020/000029.html) ++ if glibc_vers.version_compare('<2.32') ++ assert (not has_lchmod, '"lchmod" check should have failed') ++ else ++ assert (has_lchmod, '"lchmod" check should have succeeded') ++ endif + else ++ # Other C libraries for Linux should have lchmod + assert (has_lchmod, '"lchmod" check should have succeeded') + endif + else diff --git a/srcpkgs/meson/template b/srcpkgs/meson/template index 9a1afce0cfc..64a12e6d7a9 100644 --- a/srcpkgs/meson/template +++ b/srcpkgs/meson/template @@ -1,20 +1,33 @@ # Template file for 'meson' pkgname=meson -version=0.55.3 -revision=3 +version=0.56.2 +revision=1 build_style=python3-module hostmakedepends="python3-devel python3-setuptools" depends="ninja python3-setuptools" -checkdepends="glib-devel gobject-introspection libsanitizer-devel ninja +checkdepends="glib-devel gobject-introspection ninja gcc-objc++ clang qt5-devel cmake llvm git pkg-config vala python-devel cross-arm-linux-gnueabihf" short_desc="Super fast build system" maintainer="John " license="Apache-2.0" homepage="https://mesonbuild.com" -changelog="https://github.com/mesonbuild/$pkgname/blob/master/docs/markdown/Release-notes-for-${version%.*}.0.md" -distfiles="https://github.com/mesonbuild/$pkgname/releases/download/$version/$pkgname-$version.tar.gz" -checksum=6bed2a25a128bbabe97cf40f63165ebe800e4fcb46db8ab7ef5c2b5789f092a5 +changelog="https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release-notes-for-${version%.*}.0.md" +distfiles="https://github.com/mesonbuild/meson/releases/download/$version/$pkgname-$version.tar.gz" +checksum=3cb8bdb91383f7f8da642f916e4c44066a29262caa499341e2880f010edb87f4 + +# XXX: sanitizers aren't available on musl +if [ "$XBPS_TARGET_LIBC" = glibc ]; then + checkdepends+=" libsanitizer-devel" +fi + +post_patch() { + if [ "$XBPS_TARGET_LIBC" = musl ]; then + vsed -e 's/test_pch_with_address_sanitizer/_&/' \ + -e 's/test_generate_gir_with_address_sanitizer/_&/' \ + -i run_unittests.py + fi +} do_check() { # meson depends on trillion of things to perform actual tests @@ -35,5 +48,7 @@ post_install() { done vinstall data/syntax-highlighting/emacs/meson.el 644 usr/share/emacs/site-lisp - vinstall data/shell-completions/zsh/_meson 644 usr/share/zsh/site-functions + + vcompletion data/shell-completions/bash/meson bash + vcompletion data/shell-completions/zsh/_meson zsh } From 24f61b7152e246d64474d80f79f8fec2b423ecf4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89rico=20Rolim?= Date: Tue, 2 Feb 2021 17:04:39 -0300 Subject: [PATCH 2/3] seatd: fix build with meson 0.56.x. meson added some new warnings to the warning level used by seatd, including for unused arguments. This made the build generate warnings, and seatd's default of werror=true caused the build to fail. --- srcpkgs/seatd/template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/srcpkgs/seatd/template b/srcpkgs/seatd/template index d76d4d3a658..e6b6b387444 100644 --- a/srcpkgs/seatd/template +++ b/srcpkgs/seatd/template @@ -3,7 +3,7 @@ pkgname=seatd version=0.4.0 revision=1 build_style=meson -configure_args="-Dexamples=disabled $(vopt_if elogind -Dlogind=enabled)" +configure_args="-Dexamples=disabled $(vopt_if elogind -Dlogind=enabled) -Dwerror=false" hostmakedepends="pkg-config scdoc" makedepends="$(vopt_if elogind elogind-devel)" short_desc="Minimal seat management daemon" From 7247358da6376050230172c07faa65cad6ef491c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89rico=20Rolim?= Date: Tue, 2 Feb 2021 17:20:22 -0300 Subject: [PATCH 3/3] kanshi: add patch to fix ndebug build. Caught by new warnings enabled by meson update. --- srcpkgs/kanshi/patches/assert.patch | 37 +++++++++++++++++++++++++++++ srcpkgs/kanshi/template | 2 +- 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 srcpkgs/kanshi/patches/assert.patch diff --git a/srcpkgs/kanshi/patches/assert.patch b/srcpkgs/kanshi/patches/assert.patch new file mode 100644 index 00000000000..90e8e3c7bab --- /dev/null +++ b/srcpkgs/kanshi/patches/assert.patch @@ -0,0 +1,37 @@ +commit 5ff7fad0a8391c0c3ef87f48e34e4e65c584d000 +Author: Érico Rolim +Date: Tue Feb 2 17:18:42 2021 -0300 + + parser: use abort() instead of assert(0). + + assert(0) has no effect on NDEBUG builds, and means the program will + continue running in an unexpected state. + +diff --git parser.c parser.c +index 40146e8..0ed1ba1 100644 +--- parser.c ++++ parser.c +@@ -1,5 +1,4 @@ + #define _POSIX_C_SOURCE 200809L +-#include + #include + #include + #include +@@ -24,7 +23,7 @@ static const char *token_type_str(enum kanshi_token_type t) { + case KANSHI_TOKEN_NEWLINE: + return "newline"; + } +- assert(0); ++ abort(); + } + + static int parser_read_char(struct kanshi_parser *parser) { +@@ -333,7 +332,7 @@ static struct kanshi_profile_output *parse_profile_output( + } + break; + default: +- assert(0); ++ abort(); + } + has_key = false; + output->fields |= key; diff --git a/srcpkgs/kanshi/template b/srcpkgs/kanshi/template index fbef9a7e59b..e6fe40f4a69 100644 --- a/srcpkgs/kanshi/template +++ b/srcpkgs/kanshi/template @@ -1,7 +1,7 @@ # Template file for 'kanshi' pkgname=kanshi version=1.1.0 -revision=1 +revision=2 build_style=meson hostmakedepends="pkg-config scdoc wayland-devel" makedepends="wayland-devel"