From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [WIP] grub-btrfs: update to 4.8.1
Date: Wed, 03 Feb 2021 04:19:54 +0100 [thread overview]
Message-ID: <20210203031954.XWXMBf_3l2GlApw4FtYVYPsp2Omrp1QMyObv0rEN66U@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28288@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/28288#discussion_r569103232
Comment:
1. Omit the `-v` here and add some logic that will recognize a variable like `VERBOSE` that can be set in the `conf` file to govern the addition of `-v`. This could be a catch-all `OPTS` variable like other services uses, but there probably isn't much value in allowing other flags, since you want tighter control on the path and mode anyway.
2. Is mode 768 sufficient? If snapshots can be renamed, you might also need bits for `IN_MOVE` or the `IN_MOVED_{TO,FROM}`. You should do some experiments to see what kind of events a snapshot create/rename/destroy trigger.
3. You should probably verify that `SNAPSHOTS_PATH` is non-empty and either fail or substitute a default when it is.
next prev parent reply other threads:[~2021-02-03 3:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 16:37 [PR PATCH] " FollieHiyuki
2021-01-28 16:39 ` FollieHiyuki
2021-01-28 17:19 ` ericonr
2021-01-28 19:39 ` FollieHiyuki
2021-02-03 0:48 ` [PR PATCH] [Updated] [WIP] " FollieHiyuki
2021-02-03 0:53 ` FollieHiyuki
2021-02-03 1:02 ` ericonr
2021-02-03 1:05 ` [PR REVIEW] " ericonr
2021-02-03 1:18 ` [PR PATCH] [Updated] " FollieHiyuki
2021-02-03 1:18 ` FollieHiyuki
2021-02-03 1:28 ` [PR PATCH] [Updated] " FollieHiyuki
2021-02-03 1:46 ` FollieHiyuki
2021-02-03 2:03 ` [PR PATCH] [Updated] " FollieHiyuki
2021-02-03 2:05 ` FollieHiyuki
2021-02-03 2:07 ` FollieHiyuki
2021-02-03 2:49 ` ericonr
2021-02-03 3:05 ` FollieHiyuki
2021-02-03 3:19 ` [PR REVIEW] " ahesford
2021-02-03 3:19 ` ahesford [this message]
2021-02-03 5:53 ` FollieHiyuki
2021-02-03 5:53 ` [PR PATCH] [Updated] " FollieHiyuki
2021-02-15 17:23 ` ericonr
2021-02-15 18:38 ` FollieHiyuki
2021-02-20 7:13 ` [PR REVIEW] grub-btrfs: update to 4.8.1 + add runit service ericonr
2021-02-20 7:14 ` [PR PATCH] [Merged]: " ericonr
2021-02-20 13:48 ` [PR REVIEW] " FollieHiyuki
2021-02-20 14:06 ` ahesford
2021-02-20 14:30 ` FollieHiyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203031954.XWXMBf_3l2GlApw4FtYVYPsp2Omrp1QMyObv0rEN66U@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).