Re: [PR PATCH] [Updated] gnucash: update to 4.4

[manfredu <manfredu@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

There is an updated pull request by manfredu against master on the void-packages repository

https://github.com/manfredu/void-packages gnucash
https://github.com/void-linux/void-packages/pull/27504

gnucash: update to 4.4
@Hoshpak: Could you pls have a look at this PR? I'm not sure what to do about the unsuccessful checks...

A patch file from https://github.com/void-linux/void-packages/pull/27504.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnucash-27504.patch --]
[-- Type: text/x-diff, Size: 4554 bytes --]

From 5be7e0bb0ea4888355fea9c3fe56d317e9f3d284 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sat, 6 Feb 2021 20:03:01 +0100
Subject: [PATCH] gnucash: update to 4.4

Fix use-after-free in test_xaccTransEqual
Disable two tests which require having the fr_FR and de_DE locales installed.
Add tzdata as dependency
Make_check_target=check
---
 srcpkgs/gnucash/patches/disabletests.patch | 14 ++++++++++++++
 srcpkgs/gnucash/patches/fixtest.patch      | 17 +++++++++++++++++
 srcpkgs/gnucash/template                   | 13 +++++++------
 3 files changed, 38 insertions(+), 6 deletions(-)
 create mode 100644 srcpkgs/gnucash/patches/disabletests.patch
 create mode 100644 srcpkgs/gnucash/patches/fixtest.patch

diff --git a/srcpkgs/gnucash/patches/disabletests.patch b/srcpkgs/gnucash/patches/disabletests.patch
new file mode 100644
index 00000000000..fe18e21f1f1
--- /dev/null
+++ b/srcpkgs/gnucash/patches/disabletests.patch
@@ -0,0 +1,14 @@
+--- libgnucash/engine/test/CMakeLists.txt	2020-07-11 01:39:03.000000000 +0200
++++ libgnucash/engine/test/CMakeLists.txt	2021-01-31 22:22:19.782029671 +0100
+@@ -49,3 +49,3 @@ if (NOT WIN32)
+-  set(SOURCES ${test_qof_SOURCES} ${CMAKE_SOURCE_DIR}/common/test-core/unittest-support.c)
+-  add_engine_test(test-qof "${SOURCES}")
+-  target_compile_definitions(test-qof PRIVATE TESTPROG=test_qof)
++  # set(SOURCES ${test_qof_SOURCES} ${CMAKE_SOURCE_DIR}/common/test-core/unittest-support.c)
++  # add_engine_test(test-qof "${SOURCES}")
++  # target_compile_definitions(test-qof PRIVATE TESTPROG=test_qof)
+@@ -167,2 +167,2 @@ set(test_gnc_numeric_SOURCES
+-gnc_add_test(test-gnc-numeric "${test_gnc_numeric_SOURCES}"
+-  gtest_engine_INCLUDES gtest_qof_LIBS)
++# gnc_add_test(test-gnc-numeric "${test_gnc_numeric_SOURCES}"
++#   gtest_engine_INCLUDES gtest_qof_LIBS)
diff --git a/srcpkgs/gnucash/patches/fixtest.patch b/srcpkgs/gnucash/patches/fixtest.patch
new file mode 100644
index 00000000000..4404d99a534
--- /dev/null
+++ b/srcpkgs/gnucash/patches/fixtest.patch
@@ -0,0 +1,17 @@
+--- libgnucash/engine/test/utest-Transaction.cpp
++++ libgnucash/engine/test/utest-Transaction.cpp
+@@ -901,7 +901,6 @@ test_xaccTransEqual (Fixture *fixture, gconstpointer pData)
+    g_assert_cmpint (check->hits, ==, 10);
+    g_assert_cmpint (check2->hits, ==, 1);
+
+-   g_free (check->msg);
+    g_free (check2->msg);
+    check2->msg = g_strdup_printf (
+                     "[xaccTransEqual] splits %s and %s differ", split_guid0, split_guid0);
+@@ -924,6 +923,7 @@ test_xaccTransEqual (Fixture *fixture, gconstpointer pData)
+        auto bal01 = gnc_numeric_to_string (split01->balance);
+        auto bal10 = gnc_numeric_to_string (split10->balance);
+        auto bal11 = gnc_numeric_to_string (split11->balance);
++       g_free (check->msg);
+        check->msg = g_strdup_printf("[xaccSplitEqualCheckBal] balances differ: %s vs %s", bal10, bal00);
+        check3->msg = g_strdup_printf("[xaccSplitEqualCheckBal] balances differ: %s vs %s", bal11, bal01);
\ No newline at end of file
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 622b0ee6e3e..ed1143d4817 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,22 +1,23 @@
 # Template file for 'gnucash'
 pkgname=gnucash
-version=4.2
-revision=3
+version=4.4
+revision=1
 wrksrc="${pkgname}-${version%b}"
 build_style=cmake
+make_check_target=check
 configure_args="-DWITH_SQL=0 -DWITH_PYTHON=1"
 hostmakedepends="pkg-config guile python3 libxslt perl gettext swig"
 makedepends="aqbanking-devel boost-devel gc-devel glib-devel gtest-devel guile-devel
  gwenhywfar-devel ktoblzcheck-devel libofx-devel libsecret-devel
- libxslt-devel webkit2gtk-devel python3-devel gwenhywfar-gtk3"
+ libxslt-devel webkit2gtk-devel python3-devel gwenhywfar-gtk3 tzdata"
 depends="dconf guile perl"
 short_desc="Financial-accounting software"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="http://www.gnucash.org"
-#distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
-distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
-checksum=56d8ab039ef7784303ca9eab14bfc20f593f7a3f9b682a8a7eac25906a0d1308
+distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.bz2"
+#distfiles="https://sources.voidlinux.org/gnucash-${version}/gnucash-${version}.tar.bz2"
+checksum=d91e0d126b461d71de1bc1b20d9cf142704353dec07d3e6599d138422759e67a
 
 pycompile_dirs="usr/share/gnucash/python"
 conf_files="/etc/gnucash/environment"