From: circhioz <circhioz@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] gdm: enable smooth transition with plymouth.
Date: Mon, 08 Feb 2021 01:14:42 +0100 [thread overview]
Message-ID: <20210208001442.mNoMgdT5tn-ol3lGUyXoPCAbyQayIY0I_rrZyTaSlaA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28570@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
New review comment by circhioz on void-packages repository
https://github.com/void-linux/void-packages/pull/28570#discussion_r571723731
Comment:
It does absolutely nothing with the library, yet it requires `ply-boot-client.pc` to be present at configure time. Code just spawns `plymouth` binary and that's all.
The quirky logic comes from a patch written by Fedora devs 11 years ago. My best guess is that it was upstreamed without anyone knowing what it really did.
next prev parent reply other threads:[~2021-02-08 0:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 18:04 [PR PATCH] " circhioz
2021-02-07 22:15 ` [PR REVIEW] " ericonr
2021-02-08 0:10 ` circhioz
2021-02-08 0:14 ` circhioz [this message]
2021-02-08 1:42 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208001442.mNoMgdT5tn-ol3lGUyXoPCAbyQayIY0I_rrZyTaSlaA@z \
--to=circhioz@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).