From: 4ricci <4ricci@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] rclone: fix builtin version string
Date: Wed, 10 Feb 2021 18:27:46 +0100 [thread overview]
Message-ID: <20210210172746.3HIwDwLWC8MvYfQFU48mNncW35bq4_0OvMqooA1gj-s@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28633@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
There is an updated pull request by 4ricci against master on the void-packages repository
https://github.com/4ricci/void-packages rclone
https://github.com/void-linux/void-packages/pull/28633
rclone: fix builtin version string
Also:
- enable tests
- use official site for distfiles and changelog
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28633.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rclone-28633.patch --]
[-- Type: text/x-diff, Size: 1488 bytes --]
From f5f7d72b364b39f1d6771eeac868adafe3c1a7b5 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Tue, 9 Feb 2021 21:59:03 +0100
Subject: [PATCH] rclone: fix builtin version string
Also:
- enable tests
- use official site for distfiles
---
srcpkgs/rclone/template | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/rclone/template b/srcpkgs/rclone/template
index 93295ccbd5c..3c793deb6d1 100644
--- a/srcpkgs/rclone/template
+++ b/srcpkgs/rclone/template
@@ -1,17 +1,17 @@
# Template file for 'rclone'
pkgname=rclone
version=1.54.0
-revision=1
+revision=2
wrksrc="rclone-v${version}"
build_style=go
go_import_path=github.com/rclone/rclone
-go_ldflags="-extldflags=-fuse-ld=bfd"
+go_ldflags="-extldflags=-fuse-ld=bfd -X github.com/rclone/rclone/fs.Version=v${version}"
short_desc="Rsync for cloud storage"
maintainer="Diogo Leal <diogo@diogoleal.com>"
license="MIT"
homepage="https://rclone.org/"
changelog="https://raw.githubusercontent.com/rclone/rclone/master/docs/content/changelog.md"
-distfiles="https://github.com/rclone/rclone/releases/download/v${version}/rclone-v${version}.tar.gz"
+distfiles="https://downloads.rclone.org/v${version}/rclone-v${version}.tar.gz"
checksum=95f952dc059b842bd40338458b77657f7b5a1680c4ca837a3adcf83b63c8fda1
pre_build() {
@@ -23,6 +23,10 @@ pre_build() {
fi
}
+do_check() {
+ RCLONE_CONFIG="/notfound" go test ./...
+}
+
post_install() {
vlicense COPYING
vman rclone.1
next prev parent reply other threads:[~2021-02-10 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 17:21 [PR PATCH] " 4ricci
2021-02-10 17:23 ` [PR REVIEW] " ericonr
2021-02-10 17:27 ` 4ricci [this message]
2021-02-10 18:04 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210172746.3HIwDwLWC8MvYfQFU48mNncW35bq4_0OvMqooA1gj-s@z \
--to=4ricci@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).