Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gstreamer1: add missing makedepends
@ 2021-02-10 22:53 kawaiiamber
  2021-02-10 23:01 ` ericonr
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: kawaiiamber @ 2021-02-10 22:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2574 bytes --]

There is a new pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages gstreamer
https://github.com/void-linux/void-packages/pull/28657

gstreamer1: add missing makedepends
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl
-->

I noticed when building the `gstreamer1` package with `xbps-src` that it warns about missing libraries:
![1612995217](https://user-images.githubusercontent.com/30329373/107582857-52f66a00-6bb7-11eb-884a-1cd5c5c497c3.png)
![1612995198](https://user-images.githubusercontent.com/30329373/107582864-54279700-6bb7-11eb-86ac-230a905bd63c.png)

Furthermore, I notice that the [PKGBUILD](https://github.com/archlinux/svntogit-packages/blob/packages/gstreamer/trunk/PKGBUILD) on Arch includes these libraries in their template. This might help with [this](https://github.com/void-linux/void-packages/issues/25852) issue. I notice that durring the build is says that pkg-config can't find gstreamer-1.0.pc in `PKG_CONFIG_PATH`. I used `xlocate gstreamer-1.0.pc` and tried adding, as a result:
```sh
export PKG_CONFIG_PATH="${PKG_CONFIG_PATH}:${DESTDIR}/usr/lib/pkgconfig"
```
as that is the directory where `gstreamer-1.0.pc` is located, but the same warning occurs.

A patch file from https://github.com/void-linux/void-packages/pull/28657.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gstreamer-28657.patch --]
[-- Type: text/x-diff, Size: 928 bytes --]

From 3c84d56365b7d1d350b41227e305e119a733696d Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Wed, 10 Feb 2021 15:43:19 -0700
Subject: [PATCH] gstreamer1: add missing makedepends

---
 srcpkgs/gstreamer1/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gstreamer1/template b/srcpkgs/gstreamer1/template
index 629caa92e52..cda45e49173 100644
--- a/srcpkgs/gstreamer1/template
+++ b/srcpkgs/gstreamer1/template
@@ -11,7 +11,7 @@ configure_args="-Dptp-helper-permissions=capabilities
 hostmakedepends="gettext pkg-config flex python3 docbook-xsl glib-devel
  libcap-progs"
 makedepends="libxml2-devel libglib-devel gtk+3-devel libcap-devel libunwind-devel
- bash-completion"
+ bash-completion gsl-devel valgrind-devel gmp-devel"
 short_desc="Core GStreamer libraries and elements (1.x)"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.0-or-later"

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: gstreamer1: add missing makedepends
  2021-02-10 22:53 [PR PATCH] gstreamer1: add missing makedepends kawaiiamber
@ 2021-02-10 23:01 ` ericonr
  2021-02-10 23:05 ` kawaiiamber
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-02-10 23:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28657#issuecomment-777093539

Comment:
```
# Used by the gstutils test
gmp_dep = cc.find_library('gmp', required : false)
cdata.set('HAVE_GMP', gmp_dep.found())
gsl_dep = cc.find_library('gsl', required : false)
gslcblas_dep = cc.find_library('gslcblas', required : false)
cdata.set('HAVE_GSL', gsl_dep.found() and gslcblas_dep.found())
test_deps = [gmp_dep, gsl_dep, gslcblas_dep]
```

These are test dependencies only. Might make sense to add to `checkdepends`, I guess.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: gstreamer1: add missing makedepends
  2021-02-10 22:53 [PR PATCH] gstreamer1: add missing makedepends kawaiiamber
  2021-02-10 23:01 ` ericonr
@ 2021-02-10 23:05 ` kawaiiamber
  2021-02-10 23:06 ` Johnnynator
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: kawaiiamber @ 2021-02-10 23:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/28657#issuecomment-777095680

Comment:
> ```
> # Used by the gstutils test
> gmp_dep = cc.find_library('gmp', required : false)
> cdata.set('HAVE_GMP', gmp_dep.found())
> gsl_dep = cc.find_library('gsl', required : false)
> gslcblas_dep = cc.find_library('gslcblas', required : false)
> cdata.set('HAVE_GSL', gsl_dep.found() and gslcblas_dep.found())
> test_deps = [gmp_dep, gsl_dep, gslcblas_dep]
> ```
> 
> 
> These are test dependencies only. Might make sense to add to `checkdepends`, I guess.

Ah, I see. `gsl-devel` and `gmp-devel` should be moved to `checkdepends` then. I imagine `valgrind-devel` should remain in `makedepends`?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: gstreamer1: add missing makedepends
  2021-02-10 22:53 [PR PATCH] gstreamer1: add missing makedepends kawaiiamber
  2021-02-10 23:01 ` ericonr
  2021-02-10 23:05 ` kawaiiamber
@ 2021-02-10 23:06 ` Johnnynator
  2021-02-10 23:07 ` Duncaen
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Johnnynator @ 2021-02-10 23:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/28657#issuecomment-777096177

Comment:
![image](https://upload.wikimedia.org/wikipedia/commons/thumb/d/d6/A_bowl_of_rice.jpg/1200px-A_bowl_of_rice.jpg)
 
> Ah, I see. `gsl-devel` and `gmp-devel` should be moved to `checkdepends` then. I imagine `valgrind-devel` should remain in `makedepends`?

Valgrind also sounds like something that is only needed for checkdepends. You could just test if a non check builds succeeds without valgrind.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: gstreamer1: add missing makedepends
  2021-02-10 22:53 [PR PATCH] gstreamer1: add missing makedepends kawaiiamber
                   ` (2 preceding siblings ...)
  2021-02-10 23:06 ` Johnnynator
@ 2021-02-10 23:07 ` Duncaen
  2021-02-10 23:08 ` Duncaen
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Duncaen @ 2021-02-10 23:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28657#issuecomment-777096945

Comment:
Please post text instead of screenshots in the future, its searchable and accessible for everyone, especially if the text is transparent, low contrast and has random colors all over the place.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: gstreamer1: add missing makedepends
  2021-02-10 22:53 [PR PATCH] gstreamer1: add missing makedepends kawaiiamber
                   ` (3 preceding siblings ...)
  2021-02-10 23:07 ` Duncaen
@ 2021-02-10 23:08 ` Duncaen
  2021-02-10 23:10 ` [PR PATCH] [Updated] " kawaiiamber
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Duncaen @ 2021-02-10 23:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28657#issuecomment-777096945

Comment:
Please post text instead of screenshots in the future, text its searchable and accessible for everyone, especially if the text is transparent, low contrast and has random colors all over the place.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] gstreamer1: add missing makedepends
  2021-02-10 22:53 [PR PATCH] gstreamer1: add missing makedepends kawaiiamber
                   ` (4 preceding siblings ...)
  2021-02-10 23:08 ` Duncaen
@ 2021-02-10 23:10 ` kawaiiamber
  2021-02-10 23:11 ` kawaiiamber
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: kawaiiamber @ 2021-02-10 23:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2579 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages gstreamer
https://github.com/void-linux/void-packages/pull/28657

gstreamer1: add missing makedepends
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl
-->

I noticed when building the `gstreamer1` package with `xbps-src` that it warns about missing libraries:
![1612995217](https://user-images.githubusercontent.com/30329373/107582857-52f66a00-6bb7-11eb-884a-1cd5c5c497c3.png)
![1612995198](https://user-images.githubusercontent.com/30329373/107582864-54279700-6bb7-11eb-86ac-230a905bd63c.png)

Furthermore, I notice that the [PKGBUILD](https://github.com/archlinux/svntogit-packages/blob/packages/gstreamer/trunk/PKGBUILD) on Arch includes these libraries in their template. This might help with [this](https://github.com/void-linux/void-packages/issues/25852) issue. I notice that durring the build is says that pkg-config can't find gstreamer-1.0.pc in `PKG_CONFIG_PATH`. I used `xlocate gstreamer-1.0.pc` and tried adding, as a result:
```sh
export PKG_CONFIG_PATH="${PKG_CONFIG_PATH}:${DESTDIR}/usr/lib/pkgconfig"
```
as that is the directory where `gstreamer-1.0.pc` is located, but the same warning occurs.

A patch file from https://github.com/void-linux/void-packages/pull/28657.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gstreamer-28657.patch --]
[-- Type: text/x-diff, Size: 847 bytes --]

From 6194a662e4f28b15973cf6163e535cac75be6a37 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Wed, 10 Feb 2021 15:43:19 -0700
Subject: [PATCH] gstreamer1: add checkdepends

---
 srcpkgs/gstreamer1/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/gstreamer1/template b/srcpkgs/gstreamer1/template
index 629caa92e52..58a66eaf06b 100644
--- a/srcpkgs/gstreamer1/template
+++ b/srcpkgs/gstreamer1/template
@@ -12,6 +12,7 @@ hostmakedepends="gettext pkg-config flex python3 docbook-xsl glib-devel
  libcap-progs"
 makedepends="libxml2-devel libglib-devel gtk+3-devel libcap-devel libunwind-devel
  bash-completion"
+checkdepends="gsl-devel gmp-devel valgrind-devel"
 short_desc="Core GStreamer libraries and elements (1.x)"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.0-or-later"

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: gstreamer1: add missing makedepends
  2021-02-10 22:53 [PR PATCH] gstreamer1: add missing makedepends kawaiiamber
                   ` (5 preceding siblings ...)
  2021-02-10 23:10 ` [PR PATCH] [Updated] " kawaiiamber
@ 2021-02-10 23:11 ` kawaiiamber
  2021-02-10 23:20 ` gstreamer1: add checkdepends kawaiiamber
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: kawaiiamber @ 2021-02-10 23:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/28657#issuecomment-777098988

Comment:
> Please post text instead of screenshots in the future, text its searchable and accessible for everyone, especially if the text is transparent, low contrast and has random colors all over the place.

Ah, I see. Sorry about that - I was lazy ;p I moved added `-devel` packages to `checkdepends`. I'm still curious about the `PKG_CONFIG_PATH` issue.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: gstreamer1: add checkdepends
  2021-02-10 22:53 [PR PATCH] gstreamer1: add missing makedepends kawaiiamber
                   ` (6 preceding siblings ...)
  2021-02-10 23:11 ` kawaiiamber
@ 2021-02-10 23:20 ` kawaiiamber
  2021-02-10 23:49 ` ericonr
  2021-02-10 23:49 ` [PR PATCH] [Merged]: " ericonr
  9 siblings, 0 replies; 11+ messages in thread
From: kawaiiamber @ 2021-02-10 23:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/28657#issuecomment-777098988

Comment:
> Please post text instead of screenshots in the future, text its searchable and accessible for everyone, especially if the text is transparent, low contrast and has random colors all over the place.

Ah, I see. Sorry about that - I was lazy ;p I moved added `-devel` packages to `checkdepends`. I'm still curious about the `PKG_CONFIG_PATH` issue.

EDIT:
The full warning about pkg-config:
```sh
[114/477] Generating GstBase-1.0.gir with a custom command
Package gstreamer-1.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gstreamer-1.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gstreamer-1.0' found

[115/477] Generating GstBase-1.0.typelib with a custom command
```

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: gstreamer1: add checkdepends
  2021-02-10 22:53 [PR PATCH] gstreamer1: add missing makedepends kawaiiamber
                   ` (7 preceding siblings ...)
  2021-02-10 23:20 ` gstreamer1: add checkdepends kawaiiamber
@ 2021-02-10 23:49 ` ericonr
  2021-02-10 23:49 ` [PR PATCH] [Merged]: " ericonr
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-02-10 23:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28657#issuecomment-777118143

Comment:
I don't think not being able to find the file is an issue, since it is the package itself that provides it. If it ever breaks building something, we can revisit this.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Merged]: gstreamer1: add checkdepends
  2021-02-10 22:53 [PR PATCH] gstreamer1: add missing makedepends kawaiiamber
                   ` (8 preceding siblings ...)
  2021-02-10 23:49 ` ericonr
@ 2021-02-10 23:49 ` ericonr
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-02-10 23:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2406 bytes --]

There's a merged pull request on the void-packages repository

gstreamer1: add checkdepends
https://github.com/void-linux/void-packages/pull/28657

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl
-->

I noticed when building the `gstreamer1` package with `xbps-src` that it warns about missing libraries:
![1612995217](https://user-images.githubusercontent.com/30329373/107582857-52f66a00-6bb7-11eb-884a-1cd5c5c497c3.png)
![1612995198](https://user-images.githubusercontent.com/30329373/107582864-54279700-6bb7-11eb-86ac-230a905bd63c.png)

Furthermore, I notice that the [PKGBUILD](https://github.com/archlinux/svntogit-packages/blob/packages/gstreamer/trunk/PKGBUILD) on Arch includes these libraries in their template. This might help with [this](https://github.com/void-linux/void-packages/issues/25852) issue. I notice that durring the build is says that pkg-config can't find gstreamer-1.0.pc in `PKG_CONFIG_PATH`. I used `xlocate gstreamer-1.0.pc` and tried adding, as a result:
```sh
export PKG_CONFIG_PATH="${PKG_CONFIG_PATH}:${DESTDIR}/usr/lib/pkgconfig"
```
as that is the directory where `gstreamer-1.0.pc` is located, but the same warning occurs.

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-02-10 23:49 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 22:53 [PR PATCH] gstreamer1: add missing makedepends kawaiiamber
2021-02-10 23:01 ` ericonr
2021-02-10 23:05 ` kawaiiamber
2021-02-10 23:06 ` Johnnynator
2021-02-10 23:07 ` Duncaen
2021-02-10 23:08 ` Duncaen
2021-02-10 23:10 ` [PR PATCH] [Updated] " kawaiiamber
2021-02-10 23:11 ` kawaiiamber
2021-02-10 23:20 ` gstreamer1: add checkdepends kawaiiamber
2021-02-10 23:49 ` ericonr
2021-02-10 23:49 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).