From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] tvbrowser: depends on virtual java-runtime package.
Date: Sun, 14 Feb 2021 17:16:41 +0100 [thread overview]
Message-ID: <20210214161641.UTe4LX4jWMO5DJ0PO3Jnr52gmB2OA6jLflvEnqzpJjg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28504@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]
There is an updated pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages tv
https://github.com/void-linux/void-packages/pull/28504
tvbrowser: depends on virtual java-runtime package.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28504.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tv-28504.patch --]
[-- Type: text/x-diff, Size: 1210 bytes --]
From 87e2f7931c600213d203a5a62481b6f4bd02dcd2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Fri, 5 Feb 2021 01:44:55 -0300
Subject: [PATCH] tvbrowser: depends openjdk11.
It is possible to depend on `java-runtime>=11`, but only if the
openjdk11 package has already been built. Until xbps-src has a mechanism
for dealing with this, and openjdk11 is our latest java runtime,
depending directly on openjdk11 works fine.
---
srcpkgs/tvbrowser/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/tvbrowser/template b/srcpkgs/tvbrowser/template
index 5619ce740a2..3810d485928 100644
--- a/srcpkgs/tvbrowser/template
+++ b/srcpkgs/tvbrowser/template
@@ -1,8 +1,8 @@
# Template file for 'tvbrowser'
pkgname=tvbrowser
version=4.2.1
-revision=2
-depends="java-runtime>=11 hicolor-icon-theme bash"
+revision=3
+depends="openjdk11 hicolor-icon-theme bash" # XXX: openjdk11 or later version, when available
short_desc="Ad free open source TV guide for more than 1000 channels"
maintainer="Stefan Mühlinghaus <jazzman@alphabreed.com>"
license="GPL-3.0-or-later, GPL-2.0-or-later, LPPL-1.0, Apache-2.0, LGPL-2.1-or-later, custom:other"
next prev parent reply other threads:[~2021-02-14 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 4:47 [PR PATCH] " ericonr
2021-02-05 5:03 ` ericonr
2021-02-14 16:16 ` ericonr [this message]
2021-02-14 18:34 ` [PR PATCH] [Updated] " ericonr
2021-02-14 18:34 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210214161641.UTe4LX4jWMO5DJ0PO3Jnr52gmB2OA6jLflvEnqzpJjg@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).