Re: [PR PATCH] [Updated] pulseaudio: remove rtkit dependency and update to 14.2

[ericonr <ericonr@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages pulse
https://github.com/void-linux/void-packages/pull/28771

pulseaudio: remove rtkit dependency and update to 14.2
PulseAudio doesn't need rtkit available to work for basic usage, so
it's better to only pull it in when a user wants realtime (the error
messages should also be clear enough).

Since rtkit now pulls in a complex dependency in polkit, we can avoid
pulseaudio also pulling the whole thing in.

I have yet to test this throroughly. Basic functionality is fine.

@q66

A patch file from https://github.com/void-linux/void-packages/pull/28771.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pulse-28771.patch --]
[-- Type: text/x-diff, Size: 3672 bytes --]

From 51224ebdfe44a6cf18db7c26dd89ae8eba6d3634 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 14 Feb 2021 23:21:17 -0300
Subject: [PATCH 1/2] pulseaudio: update to 14.2.

Also remove rtkit dependency:

   PulseAudio doesn't need rtkit available to work for basic usage, so
   it's better to only pull it in when a user wants realtime (the error
   messages should also be clear enough).

   Since rtkit now pulls in a complex dependency in polkit, we can avoid
   pulseaudio also pulling the whole thing in.

Add comments about elogind and unit tests.

Closes: #27973 [via git-merge-pr]
---
 common/shlibs               |  4 ++--
 srcpkgs/pulseaudio/template | 11 +++++++----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index fda9284996c..8d32c3af15c 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -731,8 +731,8 @@ libasyncns.so.0 libasyncns-0.8_1
 libpulse.so.0 libpulseaudio-1.0_1
 libpulse-mainloop-glib.so.0 libpulseaudio-1.0_1
 libpulse-simple.so.0 libpulseaudio-1.0_1
-libpulsecommon-14.0.so libpulseaudio-14.0_1
-libpulsecore-14.0.so libpulseaudio-14.0_1
+libpulsecommon-14.2.so libpulseaudio-14.2_1
+libpulsecore-14.2.so libpulseaudio-14.2_1
 libprojectM.so.3 projectM-3.1.7_2
 liborc-0.4.so.0 orc-0.4.11_1
 liborc-test-0.4.so.0 orc-0.4.11_1
diff --git a/srcpkgs/pulseaudio/template b/srcpkgs/pulseaudio/template
index d54b9c5ba69..c21c39dffca 100644
--- a/srcpkgs/pulseaudio/template
+++ b/srcpkgs/pulseaudio/template
@@ -1,8 +1,9 @@
 # Template file for 'pulseaudio'
 pkgname=pulseaudio
-version=14.0
-revision=3
+version=14.2
+revision=1
 build_style=meson
+# XXX: new version should be able to enable systemd functionality using elogind
 configure_args="-Djack=enabled -Dlirc=disabled -Dhal-compat=false -Dorc=enabled
  -Dgtk=disabled -Dsystemd=disabled -Dwebrtc-aec=enabled
  -Dbluez5=true -Dbluez5-ofono-headset=false -Dbluez5-native-headset=true
@@ -14,15 +15,17 @@ makedepends="$(vopt_if avahi avahi-libs-devel) eudev-libudev-devel fftw-devel ja
  libcap-devel libcap-progs libglib-devel libltdl-devel libressl-devel
  libsndfile-devel libsoxr-devel orc-devel sbc-devel speex-devel tdb-devel
  webrtc-audio-processing-devel xcb-util-devel check-devel"
-depends="rtkit"
 conf_files="/etc/pulse/*"
 short_desc="Featureful, general-purpose sound server"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://www.freedesktop.org/wiki/Software/PulseAudio"
 distfiles="${FREEDESKTOP_SITE}/${pkgname}/releases/${pkgname}-${version}.tar.xz"
-checksum=a834775d9382b055504e5ee7625dc50768daac29329531deb6597bf05e06c261
+checksum=75d3f7742c1ae449049a4c88900e454b8b350ecaa8c544f3488a2562a9ff66f1
 python_version=3
+# FIXME: core-util-test fails
+make_check=yes
+
 system_groups="pulse-access"
 system_accounts="pulse"
 pulse_groups="audio"

From 5863cf249ddf9c21f4b3c7606625b70bcb00cbb4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 15 Feb 2021 01:47:15 -0300
Subject: [PATCH 2/2] pulseaudio-module-sndio: revbump for pulseaudio.

---
 srcpkgs/pulseaudio-module-sndio/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/pulseaudio-module-sndio/template b/srcpkgs/pulseaudio-module-sndio/template
index b43a0b40b4d..7b261e7ae06 100644
--- a/srcpkgs/pulseaudio-module-sndio/template
+++ b/srcpkgs/pulseaudio-module-sndio/template
@@ -1,7 +1,7 @@
 # Template file for 'pulseaudio-module-sndio'
 pkgname=pulseaudio-module-sndio
 version=13.0
-revision=2
+revision=3
 build_style=gnu-makefile
 make_use_env=yes
 hostmakedepends="pulseaudio pkg-config"