From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: hurl-1.0.0
Date: Tue, 16 Feb 2021 07:47:06 +0100 [thread overview]
Message-ID: <20210216064706.ALMB1Fh1bpYeTxy0H9FJXc9rYQzcjUrCjptfn6LQpH0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28439@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28439#issuecomment-779625380
Comment:
```
error[E0308]: mismatched types
--> packages/hurl/src/runner/xpath.rs:88:45
|
88 | let x = unsafe { CStr::from_ptr(c_s2) };
| ^^^^ expected `u8`, found `i8`
|
= note: expected raw pointer `*const u8`
found raw pointer `*const i8`
```
They don't test builds for ARM, this should have been detected a long while ago. Please report to upstream. chars have different default signedness on different platforms, so they should be using `c_char` from `std::os` or `libc`, not `u8` or `i8`.
next prev parent reply other threads:[~2021-02-16 6:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 15:31 [PR PATCH] " juantascon
2021-02-03 15:33 ` [PR REVIEW] " abenson
2021-02-03 15:34 ` abenson
2021-02-03 15:37 ` abenson
2021-02-03 16:06 ` [PR PATCH] [Updated] " juantascon
2021-02-03 16:06 ` juantascon
2021-02-16 6:47 ` ericonr [this message]
2022-05-03 2:14 ` github-actions
2022-05-17 2:14 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216064706.ALMB1Fh1bpYeTxy0H9FJXc9rYQzcjUrCjptfn6LQpH0@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).